diff options
| author |  Jarred Sumner <jarred@jarredsumner.com>
| 2023-07-30 23:51:43 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-07-30 23:51:43 -0700 |
| commit | 9ecae59bbb1a302977afa94fd879a0c6f8d6195f (patch) | |
| tree | 7bfff6d9c3264b8d1fce85f63891a1f3e5833a52 /src/js_ast.zig | |
| parent | 2ea7290172da21f4a9cd58232bf9c1ea0997d6e2 (diff) | |
| download | bun-9ecae59bbb1a302977afa94fd879a0c6f8d6195f.tar.gz bun-9ecae59bbb1a302977afa94fd879a0c6f8d6195f.tar.zst bun-9ecae59bbb1a302977afa94fd879a0c6f8d6195f.zip | |
Fix memory leak in response.clone(), further reduce memory usage of Request & Response (#3902)
* Atomize respsone.url & response.statusText
* Fix warning
* Atomize Request & Response URLs when possible
* Fix memory leak in response.clone()
bun/bench/snippets on jarred/atomize
❯ mem bun --smol request-response-clone.mjs
cpu: Apple M1 Max
runtime: bun 0.7.2 (arm64-darwin)
benchmark time (avg) (min … max) p75 p99 p995
-------------------------------------------------------- -----------------------------
req.clone().url 77.3 ns/iter (40.35 ns … 222.64 ns) 91.53 ns 128.11 ns 172.78 ns
resp.clone().url 162.43 ns/iter (116 ns … 337.77 ns) 177.4 ns 232.38 ns 262.65 ns
Peak memory usage: 60 MB
bun/bench/snippets on jarred/atomize
❯ mem bun-0.7.1 --smol request-response-clone.mjs
cpu: Apple M1 Max
runtime: bun 0.7.1 (arm64-darwin)
benchmark time (avg) (min … max) p75 p99 p995
-------------------------------------------------------- -----------------------------
req.clone().url 115.85 ns/iter (80.35 ns … 247.39 ns) 128.19 ns 181.93 ns 207.23 ns
resp.clone().url 252.32 ns/iter (202.6 ns … 351.07 ns) 266.56 ns 325.88 ns 334.73 ns
Peak memory usage: 1179 MB
* Update tests
* Update js_ast.zig
* Update test
---------
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Diffstat (limited to 'src/js_ast.zig')
| -rw-r--r-- | src/js_ast.zig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/js_ast.zig b/src/js_ast.zig index 358fe3197..d25c494fa 100644 --- a/src/js_ast.zig +++ b/src/js_ast.zig @@ -2367,7 +2367,6 @@ pub const E = struct { if (s.is_utf16) { var out = bun.String.createUninitializedUTF16(s.len()); - defer out.deref(); @memcpy(@constCast(out.utf16()), s.slice16()); return out.toJS(globalObject); } |