aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Derrick Farris <mr.dcfarris@gmail.com> 2023-02-15 15:48:11 -0600
committerGravatar GitHub <noreply@github.com> 2023-02-15 13:48:11 -0800
commit1c221d33b0def3810c262bd19a4bf8060389dae0 (patch)
tree578a259544ca5b95ab8661fece28559d3ed3b29c /src
parente67b4e73b57d152c4897acd66cf1347cbdf20444 (diff)
downloadbun-1c221d33b0def3810c262bd19a4bf8060389dae0.tar.gz
bun-1c221d33b0def3810c262bd19a4bf8060389dae0.tar.zst
bun-1c221d33b0def3810c262bd19a4bf8060389dae0.zip
fix(webcrypto): fix ed25519 CryptoKey.algorithm (#2082)
Diffstat (limited to 'src')
-rw-r--r--src/bun.js/bindings/webcrypto/CryptoKeyOKP.cpp20
1 files changed, 11 insertions, 9 deletions
diff --git a/src/bun.js/bindings/webcrypto/CryptoKeyOKP.cpp b/src/bun.js/bindings/webcrypto/CryptoKeyOKP.cpp
index a4138d8c9..b7dc55018 100644
--- a/src/bun.js/bindings/webcrypto/CryptoKeyOKP.cpp
+++ b/src/bun.js/bindings/webcrypto/CryptoKeyOKP.cpp
@@ -232,17 +232,19 @@ bool CryptoKeyOKP::isValidOKPAlgorithm(CryptoAlgorithmIdentifier algorithm)
auto CryptoKeyOKP::algorithm() const -> KeyAlgorithm
{
- CryptoEcKeyAlgorithm result;
+ CryptoKeyAlgorithm result;
+ // FIXME: This should be set to the actual algorithm name in the case of X25519
result.name = CryptoAlgorithmRegistry::singleton().name(algorithmIdentifier());
- switch (m_curve) {
- case NamedCurve::X25519:
- result.namedCurve = X25519;
- break;
- case NamedCurve::Ed25519:
- result.namedCurve = Ed25519;
- break;
- }
+ // This is commented out because the spec doesn't define the namedCurve field for OKP keys
+ // switch (m_curve) {
+ // case NamedCurve::X25519:
+ // result.namedCurve = X25519;
+ // break;
+ // case NamedCurve::Ed25519:
+ // result.namedCurve = Ed25519;
+ // break;
+ // }
return result;
}