aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2023-01-17 20:10:19 -0800
committerGravatar Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> 2023-01-17 20:10:19 -0800
commite0eeb1c07e95e1f872b177c7c25afe3bc5898b7c (patch)
treea385ab94687a7a9f28f3cc255229f4aec3dd9abe /src
parent216e872801a026c624ffa98cb15d73541e085735 (diff)
downloadbun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.tar.gz
bun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.tar.zst
bun-e0eeb1c07e95e1f872b177c7c25afe3bc5898b7c.zip
workaround lifetime issue
Diffstat (limited to 'src')
-rw-r--r--src/bun.js/bindings/ImportMetaObject.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bun.js/bindings/ImportMetaObject.cpp b/src/bun.js/bindings/ImportMetaObject.cpp
index 0247b5140..be46e5332 100644
--- a/src/bun.js/bindings/ImportMetaObject.cpp
+++ b/src/bun.js/bindings/ImportMetaObject.cpp
@@ -122,12 +122,12 @@ JSC_DEFINE_CUSTOM_GETTER(functionRequireResolveLazyGetter,
}
JSValue pathStringValue = require->get(globalObject, PropertyName(builtinNames.pathPrivateName()));
- JSC::Strong<JSC::JSString> pathString = JSC::Strong<JSC::JSString>(vm, pathStringValue.toStringOrNull(globalObject));
+ WTF::String pathString = pathStringValue.toWTFString(globalObject);
JSC::JSFunction* resolverFunction
= JSC::JSNativeStdFunction::create(
globalObject->vm(), globalObject, 2, "resolve"_s, [pathString_ = WTFMove(pathString)](JSC::JSGlobalObject* globalObject, JSC::CallFrame* callFrame) -> const JSC::EncodedJSValue {
- return functionRequireResolve(globalObject, callFrame, JSValue::encode(pathString_.get()));
+ return functionRequireResolve(globalObject, callFrame, JSValue::encode(jsString(globalObject->vm(), pathString_)));
});
require->putDirect(vm, builtinNames.resolvePrivateName(), resolverFunction, 0);
return JSValue::encode(JSValue(resolverFunction));
19/+34 2022-10-21Fix test failureGravatar Jarred Sumner 1-2/+3 2022-10-21Reload node:fs in developmentGravatar Jarred Sumner 1-0/+9 2022-10-21chore: remove outdated `var` usages (#1364)Gravatar Carter Snook 1-34/+34 2022-10-21Fix "/" in exampleGravatar Jarred Sumner 1-3/+10 2022-10-21Fix infinite loopGravatar Jarred Sumner 1-3/+13 2022-10-21micro-optimizeGravatar Jarred Sumner 1-7/+14 2022-10-20Update install script to use secure flagsGravatar Ashcon Partovi 2-5/+5 2022-10-20Add installation method for HomebrewGravatar Ashcon Partovi 1-0/+7 2022-10-20Fix crash in `highWaterMark`Gravatar Jarred Sumner 1-143/+144 2022-10-20Fix Bun.serve error handler error param (#1359)Gravatar zhiyuan 7-4/+37 2022-10-19Fix calling `ws.publish` inside `close` when other clients are connectedGravatar Jarred Sumner 3-28/+111 2022-10-19Cache dir loader: Prefer `$BUN_INSTALL` and `$XDG_CACHE_HOME` to `$HOME`. (#1...Gravatar Lucas Garron 1-5/+5 2022-10-19Improve issue templates (#1353)Gravatar Ashcon Partovi 8-89/+136