[Bun.connect] Fix bug where connect() Promise wouldn't reject on a connection error

1 files changed, 58 insertions, 12 deletions

diff --git a/test/bun.js/socket/socket.test.ts b/test/bun.js/socket/socket.test.ts
index 7336306fa..28c945f64 100644
--- a/test/bun.js/socket/socket.test.ts
+++ b/test/bun.js/socket/socket.test.ts
@@ -4,7 +4,7 @@ import { connect, spawn } from "bun";
 
 it("should keep process alive only when active", async () => {
   const { exited, stdout, stderr } = spawn({
-    cmd: [ bunExe(), "echo.js" ],
+    cmd: [bunExe(), "echo.js"],
     cwd: import.meta.dir,
     stdout: "pipe",
     stdin: null,
@@ -16,16 +16,16 @@ it("should keep process alive only when active", async () => {
   expect(await exited).toBe(0);
   expect(await new Response(stderr).text()).toBe("");
   var lines = (await new Response(stdout).text()).split(/\r?\n/);
-  expect(lines.filter(function(line) {
-    return line.startsWith("[Server]");
-  })).toEqual([
-    "[Server] OPENED",
-    "[Server] GOT request",
-    "[Server] CLOSED",
-  ]);
-  expect(lines.filter(function(line) {
-    return line.startsWith("[Client]");
-  })).toEqual([
+  expect(
+    lines.filter(function (line) {
+      return line.startsWith("[Server]");
+    }),
+  ).toEqual(["[Server] OPENED", "[Server] GOT request", "[Server] CLOSED"]);
+  expect(
+    lines.filter(function (line) {
+      return line.startsWith("[Client]");
+    }),
+  ).toEqual([
     "[Client] OPENED",
     "[Client] GOT response",
     "[Client] ENDED",
@@ -33,7 +33,53 @@ it("should keep process alive only when active", async () => {
   ]);
 });
 
-it("should handle connection error", done => {
+it("should reject on connection error, calling both connectError() and rejecting the promise", (done) => {
+  var data = {};
+  connect({
+    data,
+    hostname: "127.0.0.1",
+    port: 55555,
+    socket: {
+      connectError(socket, error) {
+        expect(socket).toBeDefined();
+        expect(socket.data).toBe(data);
+        expect(error).toBeDefined();
+        expect(error.name).toBe("SystemError");
+        expect(error.message).toBe("Failed to connect");
+      },
+      data() {
+        done(new Error("Unexpected data()"));
+      },
+      drain() {
+        done(new Error("Unexpected drain()"));
+      },
+      close() {
+        done(new Error("Unexpected close()"));
+      },
+      end() {
+        done(new Error("Unexpected end()"));
+      },
+      error() {
+        done(new Error("Unexpected error()"));
+      },
+      open() {
+        done(new Error("Unexpected open()"));
+      },
+    },
+  }).then(
+    () => done(new Error("Promise should reject instead")),
+    (err) => {
+      expect(err).toBeDefined();
+      expect(err.name).toBe("SystemError");
+      expect(err.message).toBe("Failed to connect");
+
+      done();
+    },
+  );
+});
+
+// this also tests we mark the promise as handled if connectError() is called
+it("should handle connection error", (done) => {
   var data = {};
   connect({
     data,