diff options
author | 2023-09-14 20:30:30 -0400 | |
---|---|---|
committer | 2023-09-14 17:30:30 -0700 | |
commit | e8d58f24af4e3e12794894b2419d5cb37960b77e (patch) | |
tree | 381ad2d4d4d5aa418d437abb6b7ab14655b9f814 /test/js/node/net/node-net.test.ts | |
parent | 07b10bbc16ab16ba73f3990f3b888e98661aabea (diff) | |
download | bun-e8d58f24af4e3e12794894b2419d5cb37960b77e.tar.gz bun-e8d58f24af4e3e12794894b2419d5cb37960b77e.tar.zst bun-e8d58f24af4e3e12794894b2419d5cb37960b77e.zip |
fix(runtime): emit `node:net` connect error event vs throw (#5336)
* fix(runtime): emit `node:net` connect error event vs throw
* oops
* finally
* ok
* we are good
Diffstat (limited to 'test/js/node/net/node-net.test.ts')
-rw-r--r-- | test/js/node/net/node-net.test.ts | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/test/js/node/net/node-net.test.ts b/test/js/node/net/node-net.test.ts index efdff4bc5..109391af5 100644 --- a/test/js/node/net/node-net.test.ts +++ b/test/js/node/net/node-net.test.ts @@ -370,8 +370,36 @@ it("should handle connection error", done => { } errored = true; expect(error).toBeDefined(); - expect(error.name).toBe("SystemError"); expect(error.message).toBe("Failed to connect"); + expect((error as any).code).toBe("ECONNREFUSED"); + }); + + socket.on("connect", () => { + done(new Error("Should not have connected")); + }); + + socket.on("close", () => { + expect(errored).toBe(true); + done(); + }); +}); + +it("should handle connection error (unix)", done => { + let errored = false; + + // @ts-ignore + const socket = connect("loser", () => { + done(new Error("Should not have connected")); + }); + + socket.on("error", error => { + if (errored) { + return done(new Error("Should not have errored twice")); + } + errored = true; + expect(error).toBeDefined(); + expect(error.message).toBe("Failed to connect"); + expect((error as any).code).toBe("ENOENT"); }); socket.on("connect", () => { |