diff options
Diffstat (limited to 'src/resolver/package_json.zig')
| -rw-r--r-- | src/resolver/package_json.zig | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/resolver/package_json.zig b/src/resolver/package_json.zig index 00b736eba..90a9392f6 100644 --- a/src/resolver/package_json.zig +++ b/src/resolver/package_json.zig @@ -479,6 +479,11 @@ pub const PackageJSON = struct { .main_fields = MainFieldMap.init(r.allocator), }; + // Note: we tried rewriting this to be fewer loops over all the properties (asProperty loops over each) + // The end result was: it's not faster! Sometimes, it's slower. + // It's hard to say why. + // Feels like a codegen issue. + // or that looping over every property doesn't really matter because most package.jsons are < 20 properties if (json.asProperty("version")) |version_json| { if (version_json.expr.asString(r.allocator)) |version_str| { if (version_str.len > 0) { |