aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/javascript/jsc/bindings/bindings.zig1
-rw-r--r--src/javascript/jsc/node/types.zig7
2 files changed, 4 insertions, 4 deletions
diff --git a/src/javascript/jsc/bindings/bindings.zig b/src/javascript/jsc/bindings/bindings.zig
index 2d384a924..35f565bc2 100644
--- a/src/javascript/jsc/bindings/bindings.zig
+++ b/src/javascript/jsc/bindings/bindings.zig
@@ -136,6 +136,7 @@ pub const ZigString = extern struct {
return @intToPtr([*]u8, @ptrToInt(this.ptr))[0..this.len];
}
+ /// Does nothing if the slice is not allocated
pub fn deinit(this: *const Slice) void {
if (!this.allocated) {
return;
diff --git a/src/javascript/jsc/node/types.zig b/src/javascript/jsc/node/types.zig
index 1bf44e211..36978f7d4 100644
--- a/src/javascript/jsc/node/types.zig
+++ b/src/javascript/jsc/node/types.zig
@@ -190,10 +190,9 @@ pub const Encoding = enum(u8) {
const Eight = strings.ExactSizeMatcher(8);
/// Caller must verify the value is a string
pub fn fromStringValue(value: JSC.JSValue, global: *JSC.JSGlobalObject) ?Encoding {
- var str = JSC.ZigString.Empty;
- value.toZigString(&str, global);
- const slice = str.slice();
- return from(slice);
+ var sliced = value.toSlice(global, bun.default_allocator);
+ defer sliced.deinit();
+ return from(sliced.slice());
}
/// Caller must verify the value is a string