From 65d0884361f349f06f461c7a7be7e2dc12479e54 Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Thu, 27 Jul 2023 18:01:01 -0700 Subject: Update pull_request_template.md --- .github/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index af4fd9990..a71a6c6e5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -34,6 +34,10 @@ If Zig files changed: - [ ] I included a test for the new code, or an existing test covers it - [ ] JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed +If new methods, getters, or setters were added to a publicly exposed class: + +- [ ] I added TypeScript types for the new methods, getters, or setters + If dependencies in tests changed: - [ ] I made sure that specific versions of dependencies are used instead of ranged or tagged versions -- cgit v1.2.3