From 45dfc72a5d3059d0a6565786d1006568f9a75c94 Mon Sep 17 00:00:00 2001
From: Dylan Conway <dylan.conway567@gmail.com>
Date: Mon, 30 Jan 2023 19:23:31 -0800
Subject: set done callback state to fulfilled

---
 src/bun.js/test/jest.zig               |  4 +-
 test/bun.js/child_process-node.test.js | 86 +++++++++++++++++++---------------
 2 files changed, 50 insertions(+), 40 deletions(-)

diff --git a/src/bun.js/test/jest.zig b/src/bun.js/test/jest.zig
index 1ae0bd51a..c491cf3fb 100644
--- a/src/bun.js/test/jest.zig
+++ b/src/bun.js/test/jest.zig
@@ -2099,7 +2099,9 @@ pub const TestRunnerTask = struct {
                 std.debug.assert(this.sync_state == .pending);
                 this.sync_state = .fulfilled;
             },
-            .unhandledRejection => {},
+            .unhandledRejection => {
+                this.done_callback_state = .fulfilled;
+            },
             else => @compileError("Bad from"),
         }
 
diff --git a/test/bun.js/child_process-node.test.js b/test/bun.js/child_process-node.test.js
index 63bb8470a..56e330457 100644
--- a/test/bun.js/child_process-node.test.js
+++ b/test/bun.js/child_process-node.test.js
@@ -318,47 +318,55 @@ describe("child_process cwd", () => {
   //   // }
   // });
 
-  it("should work for valid given cwd", (done) => {
-    const tmpdir = { path: platformTmpDir };
-    const createDone = createDoneDotAll(done);
-
-    // Assume these exist, and 'pwd' gives us the right directory back
-    testCwd(
-      { cwd: tmpdir.path },
-      {
-        expectPidType: "number",
-        expectCode: 0,
-        expectData: platformTmpDir,
-      },
-      createDone(1500),
-    );
-    const shouldExistDir = "/dev";
-    testCwd(
-      { cwd: shouldExistDir },
-      {
-        expectPidType: "number",
-        expectCode: 0,
-        expectData: shouldExistDir,
-      },
-      createDone(1500),
-    );
-    testCwd(
-      { cwd: Bun.pathToFileURL(tmpdir.path) },
-      {
-        expectPidType: "number",
-        expectCode: 0,
-        expectData: platformTmpDir,
-      },
-      createDone(1500),
-    );
+  describe("it should work for valid given cwd", () => {
+    it("temp dir", (done) => {
+      const tmpdir = { path: platformTmpDir };
+      testCwd(
+        { cwd: tmpdir.path },
+        {
+          expectPidType: "number",
+          expectCode: 0,
+          expectData: platformTmpDir,
+        },
+        done,
+      );
+    });
+    it("/dev dir", (done) => {
+      const shouldExistDir = "/dev";
+      testCwd(
+        { cwd: shouldExistDir },
+        {
+          expectPidType: "number",
+          expectCode: 0,
+          expectData: shouldExistDir,
+        },
+        done,
+      );
+    });
+    it("file url", (done) => {
+      const tmpdir = { path: platformTmpDir };
+      testCwd(
+        { cwd: Bun.pathToFileURL(tmpdir.path) },
+        {
+          expectPidType: "number",
+          expectCode: 0,
+          expectData: platformTmpDir,
+        },
+        done,
+      );
+    });
   });
 
-  it.skip("shouldn't try to chdir to an invalid cwd", (done) => {
-    const createDone = createDoneDotAll(done);
-    // Spawn() shouldn't try to chdir() to invalid arg, so this should just work
-    testCwd({ cwd: "" }, { expectPidType: "number" }, createDone(1500));
-    testCwd({ cwd: undefined }, { expectPidType: "number" }, createDone(1500));
-    testCwd({ cwd: null }, { expectPidType: "number" }, createDone(1500));
+  describe("it shouldn't try to chdir to an invalid cwd", () => {
+    it("empty string", (done) => {
+      testCwd({ cwd: "" }, { expectPidType: "number" }, done);
+    });
+    it("undefined cwd", (done) => {
+      testCwd({ cwd: undefined }, { expectPidType: "number" }, done);
+    });
+    it("null cwd", (done) => {
+      testCwd({ cwd: null }, { expectPidType: "number" }, done);
+    });
   });
 });
 
-- 
cgit v1.2.3