From eb3123adb8237733a1581d47f8e898d97e807729 Mon Sep 17 00:00:00 2001
From: Martin Feckie <mfeckie@gmail.com>
Date: Sat, 20 Nov 2021 08:54:31 +0800
Subject: Add information about node modules

---
 README.md | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/README.md b/README.md
index ca8e9095d..4a3bb5b4e 100644
--- a/README.md
+++ b/README.md
@@ -982,6 +982,15 @@ make vendor jsc identifier-cache dev
 
 Verify it worked:
 
+First ensure the node dependencies are installed
+
+```bash
+cd integration/snippets
+npm i
+```
+
+Then
+
 ```bash
 make test-dev-all
 ```
@@ -1037,6 +1046,15 @@ make vendor dev
 
 Verify it worked:
 
+First ensure the node dependencies are installed
+
+```bash
+cd integration/snippets
+npm i
+```
+
+Then
+
 ```bash
 make test-dev-all
 ```
-- 
cgit v1.2.3


From 38879cd3d9d93df496a2e679a99e6fed0c6d58c7 Mon Sep 17 00:00:00 2001
From: Martin Feckie <mfeckie@gmail.com>
Date: Sat, 20 Nov 2021 09:17:04 +0800
Subject: Add information about code signing

---
 README.md | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 4a3bb5b4e..bacfafb3b 100644
--- a/README.md
+++ b/README.md
@@ -961,7 +961,7 @@ export CPPFLAGS="$CPPFLAGS -I$(brew --prefix llvm@12)/include"
 
 On fish that looks like `fish_add_path (brew --prefix llvm@12)/bin`
 
-Compile Zig:
+### Compile Zig
 
 ```bash
 git clone https://github.com/jarred-sumner/zig
@@ -970,8 +970,18 @@ git checkout jarred/zig-sloppy-with-small-structs
 cmake . -DCMAKE_PREFIX_PATH=$(brew --prefix llvm@12) -DZIG_STATIC_LLVM=ON -DCMAKE_BUILD_TYPE=Release && make -j 16
 ```
 
+Note that `brew install zig` won't work. Bun uses a build of Zig with a couple patches.
+
+Additionally, you'll need `cmake`, `npm` and `esbuild` installed globally.
+
 You'll want to make sure `zig` is in `$PATH`. The `zig` binary wil be in the same folder as the newly-cloned `zig` repo. If you use fish, you can run `fish_add_path (pwd)`.
 
+### Build bun
+
+If you're building on an Apple Silicon device, you'll need to do is ensure you have set an environment variable `CODESIGN_IDENTITY`.  You can find the correct value by visiting `Keychain Access` and looking under your `login` profile for `Certificates`.  The name would usually look like `Apple Development: user@example.com (WDYABC123)`
+
+If you're not familiar with the process, there's a guide [here](https://ioscodesigning.com/generating-code-signing-files/#generate-a-code-signing-certificate-using-xcode)
+
 In `bun`:
 
 ```bash
@@ -980,7 +990,7 @@ git submodule update --init --recursive --progress --depth=1
 make vendor jsc identifier-cache dev
 ```
 
-Verify it worked:
+### Verify it worked
 
 First ensure the node dependencies are installed
 
@@ -992,12 +1002,11 @@ npm i
 Then
 
 ```bash
+# if you're not already in the bun root directory
+cd ../../
 make test-dev-all
 ```
 
-Note that `brew install zig` won't work. Bun uses a build of Zig with a couple patches.
-
-Additionally, you'll need `cmake`, `npm` and `esbuild` installed globally.
 
 ### Troubleshooting
 
@@ -1044,7 +1053,7 @@ Compile Bun:
 make vendor dev
 ```
 
-Verify it worked:
+### Verify it worked
 
 First ensure the node dependencies are installed
 
@@ -1056,6 +1065,8 @@ npm i
 Then
 
 ```bash
+# if you're not already in the bun root directory
+cd ../../
 make test-dev-all
 ```
 
-- 
cgit v1.2.3