From c530ead1e0128bcddce258ef33a2a0b6dc89f60f Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Mon, 23 Jan 2023 04:06:01 -0800 Subject: Add a comment --- src/bun.js/api/server.zig | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'src/bun.js/api/server.zig') diff --git a/src/bun.js/api/server.zig b/src/bun.js/api/server.zig index 3612e7d3e..f4f4907f1 100644 --- a/src/bun.js/api/server.zig +++ b/src/bun.js/api/server.zig @@ -704,14 +704,16 @@ fn NewRequestContext(comptime ssl_enabled: bool, comptime debug_mode: bool, comp const arguments = callframe.arguments(2); var ctx = arguments.ptr[1].asPromisePtr(@This()); const result = arguments.ptr[0]; + result.ensureStillAlive(); + ctx.pending_promises_for_abort -|= 1; if (ctx.aborted) { ctx.finalizeForAbort(); return JSValue.jsUndefined(); } - if (result.isEmptyOrUndefinedOrNull()) { - ctx.renderMissing(); + if (ctx.didUpgradeWebSocket()) { + ctx.finalize(); return JSValue.jsUndefined(); } @@ -720,12 +722,7 @@ fn NewRequestContext(comptime ssl_enabled: bool, comptime debug_mode: bool, comp } fn handleResolve(ctx: *RequestContext, value: JSC.JSValue) void { - if (ctx.didUpgradeWebSocket()) { - ctx.finalize(); - return; - } - - if (value.isEmptyOrUndefinedOrNull()) { + if (value.isEmptyOrUndefinedOrNull() or !value.isCell()) { ctx.renderMissing(); return; } -- cgit v1.2.3