From eddb0078b5c9ff49bf67c0f1b1c2c623f0480b77 Mon Sep 17 00:00:00 2001 From: dave caruso Date: Fri, 29 Sep 2023 16:17:54 -0700 Subject: fix(runtime): followup for `server.requestIP` (#6185) * fix(runtime): followup for `server.requestIP` * oops * yeah * sure * Update src/deps/libuwsockets.cpp * Update Dockerfile * lol --------- Co-authored-by: Jarred Sumner Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> --- src/bun.js/bindings/JSSocketAddress.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/bun.js/bindings/JSSocketAddress.cpp') diff --git a/src/bun.js/bindings/JSSocketAddress.cpp b/src/bun.js/bindings/JSSocketAddress.cpp index 53084adb6..181507339 100644 --- a/src/bun.js/bindings/JSSocketAddress.cpp +++ b/src/bun.js/bindings/JSSocketAddress.cpp @@ -9,8 +9,7 @@ using namespace JSC; namespace Bun { namespace JSSocketAddress { -// Using a structure with inlined offsets will be more lightweight than a class. - +// Using a structure with inlined offsets should be more lightweight than a class. Structure* createStructure(VM& vm, JSGlobalObject* globalObject) { JSC::Structure* structure = globalObject->structureCache().emptyObjectStructureForPrototype( @@ -48,13 +47,16 @@ Structure* createStructure(VM& vm, JSGlobalObject* globalObject) extern "C" JSObject* JSSocketAddress__create(JSGlobalObject* globalObject, JSString* value, int32_t port, bool isIPv6) { + static const NeverDestroyed IPv4 = MAKE_STATIC_STRING_IMPL("IPv4"); + static const NeverDestroyed IPv6 = MAKE_STATIC_STRING_IMPL("IPv6"); + VM& vm = globalObject->vm(); auto* global = jsCast(globalObject); JSObject* thisObject = constructEmptyObject(vm, global->JSSocketAddressStructure()); thisObject->putDirectOffset(vm, 0, value); - thisObject->putDirectOffset(vm, 1, isIPv6 ? jsString(vm, Bun::JSSocketAddress::IPv6) : jsString(vm, Bun::JSSocketAddress::IPv4)); + thisObject->putDirectOffset(vm, 1, isIPv6 ? jsString(vm, IPv6) : jsString(vm, IPv4)); thisObject->putDirectOffset(vm, 2, jsNumber(port)); return thisObject; -- cgit v1.2.3