From 1a7418e890360feaa66abfdb69d588cfef8dc1f9 Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Wed, 5 Oct 2022 17:59:30 -0700 Subject: Mark these strings as not needing to be GC'd --- src/bun.js/bindings/Process.cpp | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) (limited to 'src/bun.js/bindings/Process.cpp') diff --git a/src/bun.js/bindings/Process.cpp b/src/bun.js/bindings/Process.cpp index 7baba4833..d9a908541 100644 --- a/src/bun.js/bindings/Process.cpp +++ b/src/bun.js/bindings/Process.cpp @@ -12,6 +12,8 @@ namespace Zig { using namespace JSC; +#define REPORTED_NODE_VERSION "18.10.1" + using JSGlobalObject = JSC::JSGlobalObject; using Exception = JSC::Exception; using JSValue = JSC::JSValue; @@ -473,24 +475,24 @@ JSC_DEFINE_CUSTOM_GETTER(Process_getVersionsLazy, JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(REPORTED_NODE_VERSION)))); object->putDirect( vm, JSC::Identifier::fromString(vm, "bun"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__version + 1 /* prefix with v */)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__version + 1 /* prefix with v */)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "webkit"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(BUN_WEBKIT_VERSION)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(BUN_WEBKIT_VERSION)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "mimalloc"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_mimalloc)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_mimalloc)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "libarchive"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_libarchive)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_libarchive)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "picohttpparser"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_picohttpparser)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_picohttpparser)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "boringssl"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_boringssl)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_boringssl)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "zlib"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_zlib)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_zlib)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "zig"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString(Bun__versions_zig)))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString(Bun__versions_zig)))); object->putDirect(vm, JSC::Identifier::fromString(vm, "modules"_s), - JSC::JSValue(JSC::jsString(vm, makeAtomString("67")))); + JSC::JSValue(JSC::jsOwnedString(vm, makeAtomString("67")))); thisObject->putDirect(vm, clientData->builtinNames().versionsPrivateName(), object); return JSC::JSValue::encode(object); -- cgit v1.2.3