From bac7526c03edee6e7cf947c0ea4a64d0ba411270 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Wed, 14 Jun 2023 04:01:28 -0700 Subject: Make `Bun.argv` the same as `process.argv` (#3310) Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> --- src/bun.js/bindings/Process.cpp | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'src/bun.js/bindings/Process.cpp') diff --git a/src/bun.js/bindings/Process.cpp b/src/bun.js/bindings/Process.cpp index ad8e5d073..69ee11e60 100644 --- a/src/bun.js/bindings/Process.cpp +++ b/src/bun.js/bindings/Process.cpp @@ -825,16 +825,12 @@ JSC_DEFINE_CUSTOM_GETTER(Process_getArgv, (JSC::JSGlobalObject * globalObject, J if (!thisObject) { return JSValue::encode(JSC::jsUndefined()); } - auto clientData = WebCore::clientData(vm); - - if (JSC::JSValue argv = thisObject->getIfPropertyExists( - globalObject, clientData->builtinNames().argvPrivateName())) { - return JSValue::encode(argv); - } JSC::EncodedJSValue argv_ = Bun__Process__getArgv(globalObject); - thisObject->putDirect(vm, clientData->builtinNames().argvPrivateName(), - JSC::JSValue::decode(argv_)); + auto clientData = WebCore::clientData(vm); + + thisObject->putDirect(vm, clientData->builtinNames().argvPublicName(), + JSC::JSValue::decode(argv_), 0); return argv_; } @@ -852,7 +848,7 @@ JSC_DEFINE_CUSTOM_SETTER(Process_setArgv, auto clientData = WebCore::clientData(vm); - return thisObject->putDirect(vm, clientData->builtinNames().argvPrivateName(), + return thisObject->putDirect(vm, clientData->builtinNames().argvPublicName(), JSC::JSValue::decode(value)); } -- cgit v1.2.3