From aa456805ddc9fd44152d73888ecb8733b60f34b9 Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Mon, 23 Jan 2023 15:08:27 -0800 Subject: [napi] Handle missing description in `napi_create_symbol` --- src/bun.js/bindings/napi.cpp | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) (limited to 'src/bun.js/bindings/napi.cpp') diff --git a/src/bun.js/bindings/napi.cpp b/src/bun.js/bindings/napi.cpp index 24541755f..db70ad1ca 100644 --- a/src/bun.js/bindings/napi.cpp +++ b/src/bun.js/bindings/napi.cpp @@ -1602,6 +1602,37 @@ extern "C" napi_status napi_create_bigint_words(napi_env env, return napi_ok; } +extern "C" napi_status napi_create_symbol(napi_env env, napi_value description, + napi_value* result) +{ + Zig::GlobalObject* globalObject = toJS(env); + JSC::VM& vm = globalObject->vm(); + + if (UNLIKELY(result == nullptr || globalObject == nullptr)) { + return napi_invalid_arg; + } + + JSC::JSValue descriptionValue = toJS(description); + if (descriptionValue && !descriptionValue.isUndefinedOrNull()) { + if (!descriptionValue.isString()) { + return napi_string_expected; + } + + JSC::JSString* descriptionString = descriptionValue.toStringOrNull(globalObject); + if (UNLIKELY(!descriptionString)) { + return napi_generic_failure; + } + + if (descriptionString->length() > 0) { + *result = toNapi(JSC::Symbol::createWithDescription(vm, descriptionString->value(globalObject))); + return napi_ok; + } + } + + *result = toNapi(JSC::Symbol::create(vm)); + return napi_ok; +} + extern "C" napi_status napi_call_function(napi_env env, napi_value recv_napi, napi_value func_napi, size_t argc, const napi_value* argv, -- cgit v1.2.3