From 967ccb5d50b3ce163bb98fd125c56b039743de90 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Sun, 23 Jul 2023 22:37:48 -0700 Subject: Upgrade WebKit (#3777) * Upgrade to latest WebKit * Upgrade WebKit * hm * Fix failing tests * Delete utf8-encoding-fixture.bin.cmp --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> --- src/bun.js/bindings/webcore/JSTextEncoder.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/bun.js/bindings/webcore/JSTextEncoder.cpp') diff --git a/src/bun.js/bindings/webcore/JSTextEncoder.cpp b/src/bun.js/bindings/webcore/JSTextEncoder.cpp index 5d764619b..3029028fe 100644 --- a/src/bun.js/bindings/webcore/JSTextEncoder.cpp +++ b/src/bun.js/bindings/webcore/JSTextEncoder.cpp @@ -216,9 +216,9 @@ template<> void JSTextEncoderDOMConstructor::initializeProperties(VM& vm, JSDOMG constexpr JSC::DFG::AbstractHeapKind heapKinds[4] = { JSC::DFG::HeapObjectCount }; -// This is the equivalent of DataView.set -constexpr JSC::DFG::AbstractHeapKind encodeIntoRead[4] = { JSC::DFG::MiscFields, JSC::DFG::TypedArrayProperties, JSC::DFG::Absolute }; -constexpr JSC::DFG::AbstractHeapKind encodeIntoWrite[4] = { JSC::DFG::TypedArrayProperties, JSC::DFG::Absolute }; +// TODO: figure out why the test fails after JSC upgrade and re-enable this! +// constexpr JSC::DFG::AbstractHeapKind encodeIntoRead[4] = { JSC::DFG::Heap, JSC::DFG::MiscFields, JSC::DFG::TypedArrayProperties, JSC::DFG::Absolute }; +// constexpr JSC::DFG::AbstractHeapKind encodeIntoWrite[4] = { JSC::DFG::SideState, JSC::DFG::Absolute, JSC::DFG::JSCell_structureID, JSC::DFG::HeapObjectCount }; static const JSC::DOMJIT::Signature DOMJITSignatureForJSTextEncoderEncodeWithoutTypeCheck( jsTextEncoderEncodeWithoutTypeCheck, @@ -230,10 +230,9 @@ static const JSC::DOMJIT::Signature DOMJITSignatureForJSTextEncoderEncodeWithout static const JSC::DOMJIT::Signature DOMJITSignatureForJSTextEncoderEncodeIntoWithoutTypeCheck( jsTextEncoderPrototypeFunction_encodeIntoWithoutTypeCheck, JSTextEncoder::info(), - // this is slightly incorrect - // there could be cases where the object returned by encodeInto will appear to be reused - // it impacts HeapObjectCount - JSC::DOMJIT::Effect::forReadWriteKinds(encodeIntoRead, encodeIntoWrite), + + JSC::DOMJIT::Effect {}, + // JSC::DOMJIT::Effect::forReadWriteKinds(encodeIntoRead, encodeIntoWrite), DOMJIT::IDLResultTypeFilter::value, DOMJIT::IDLArgumentTypeFilter::value, DOMJIT::IDLArgumentTypeFilter::value); -- cgit v1.2.3 thout-dash'>dave/install-tag-without-dash Unnamed repository; edit this file 'description' to name the repository.
aboutsummaryrefslogtreecommitdiff
AgeCommit message (Expand)AuthorFilesLines
2022-05-09Update bindings.cppGravatar Jarred Sumner 1-4/+6
2022-05-09[napi] Move some code to C++ for perfGravatar Jarred Sumner 2-158/+181
2022-05-09[napi] Support `import` and `require` of `.node` modulesGravatar Jarred Sumner 6-53/+80
2022-05-09[napi] Fix stringsGravatar Jarred Sumner 1-108/+142
2022-05-09fixupGravatar Jarred Sumner 2-40/+45
2022-05-09[JS Parser] Support `__dirname` and `__filename`Gravatar Jarred Sumner 1-28/+44
2022-05-08Make a lot more stuff workGravatar Jarred Sumner 5-91/+220