From a2cfdf0e1c0353428f0682969e3fcfa86cc2d6a7 Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Sat, 21 Jan 2023 23:03:43 -0800 Subject: Refactor `new Buffer` to pass Node.js tests --- src/bun.js/builtins/js/JSBufferConstructor.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/bun.js/builtins/js/JSBufferConstructor.js') diff --git a/src/bun.js/builtins/js/JSBufferConstructor.js b/src/bun.js/builtins/js/JSBufferConstructor.js index 4c3650360..10994394e 100644 --- a/src/bun.js/builtins/js/JSBufferConstructor.js +++ b/src/bun.js/builtins/js/JSBufferConstructor.js @@ -31,16 +31,12 @@ function from(items) { if (!@isConstructor(this)) @throwTypeError("Buffer.from requires |this| to be a constructor"); - if (@isUndefinedOrNull(items)) + if (@isUndefinedOrNull(items)) { @throwTypeError( "The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object.", ); - - if (@argumentCount() === 1 && @isTypedArrayView(items)) { - var out = this.allocUnsafe(items.byteLength); - out.copy(items); - return out; } + // TODO: figure out why private symbol not found if ( -- cgit v1.2.3