From bdbb637b3d870f1955cadd342eeae0147f50c3de Mon Sep 17 00:00:00 2001
From: Keyhan Vakil <kvakil@sylph.kvakil.me>
Date: Mon, 19 Jun 2023 23:28:40 -0700
Subject: implement more of V8's stack trace API (#3359)

- fix source map positions for getLineNumber / getColumnNumber
- fix return value getting coerced to a string
- implement CallFrame.p.toString
- add tests for getFunction, getThis, isConstructor, isNative, toString,
  getLineNumber, getColumnNumber

still not implemented:
- isPromiseAll/getPromiseIndex
- getEvalOrigin
- getScriptHash
- getPosition
- getEnclosingColumnNumber/getEnclosingLineNumber
- isAsync
- accessing Error.stack should call prepareStackTrace

still broken:
- isEval: often returns false when it should return true
- isToplevel: often returns true when it should return false

Refs: https://v8.dev/docs/stack-trace-api
Refs: v8/src/objects/call-site-info.cc
Fixes: https://github.com/oven-sh/bun/issues/2883
---
 src/bun.js/javascript.zig | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'src/bun.js/javascript.zig')

diff --git a/src/bun.js/javascript.zig b/src/bun.js/javascript.zig
index 63d024ad7..d458b6e7e 100644
--- a/src/bun.js/javascript.zig
+++ b/src/bun.js/javascript.zig
@@ -1983,6 +1983,9 @@ pub const VirtualMachine = struct {
             )) |mapping| {
                 frames[i].position.line = mapping.original.lines;
                 frames[i].position.column_start = mapping.original.columns;
+                frames[i].remapped = true;
+            } else {
+                frames[i].remapped = true;
             }
         }
     }
-- 
cgit v1.2.3