From 1b8f5697929812d4c7abd0edff8ad1e8f12b4e14 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Mon, 21 Aug 2023 03:31:33 -0700 Subject: Fix memory leak in `buffer.toString("hex")` (#4235) Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> --- src/bun.js/webcore/encoding.zig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/bun.js') diff --git a/src/bun.js/webcore/encoding.zig b/src/bun.js/webcore/encoding.zig index 32efb3168..890dad7bd 100644 --- a/src/bun.js/webcore/encoding.zig +++ b/src/bun.js/webcore/encoding.zig @@ -866,12 +866,14 @@ pub const Encoder = struct { } var str = bun.String.createUninitialized(.latin1, len) orelse return ZigString.init("Out of memory").toErrorInstance(global); + defer str.deref(); + strings.copyLatin1IntoASCII(@constCast(str.latin1()), input); return str.toJS(global); }, .latin1 => { var str = bun.String.createUninitialized(.latin1, len) orelse return ZigString.init("Out of memory").toErrorInstance(global); - + defer str.deref(); @memcpy(@constCast(str.latin1()), input_ptr[0..len]); return str.toJS(global); @@ -901,6 +903,8 @@ pub const Encoder = struct { .hex => { var str = bun.String.createUninitialized(.latin1, len * 2) orelse return ZigString.init("Out of memory").toErrorInstance(global); + defer str.deref(); + var output = @constCast(str.latin1()); const wrote = strings.encodeBytesToHex(output, input); std.debug.assert(wrote == output.len); -- cgit v1.2.3