From 5ae8e5d773c6b57fe166681ffa9cdc153f69427b Mon Sep 17 00:00:00 2001 From: dave caruso Date: Sat, 24 Jun 2023 02:23:39 -0400 Subject: Make node-fallbacks build as esm not cjs / Fix `node-fetch` (#3377) * Make node-fallbacks build as esm not cjs. * fix stuff --- src/node-fallbacks/node-fetch.js | 1 - 1 file changed, 1 deletion(-) (limited to 'src/node-fallbacks/node-fetch.js') diff --git a/src/node-fallbacks/node-fetch.js b/src/node-fallbacks/node-fetch.js index f124e6461..a66d8fc7f 100644 --- a/src/node-fallbacks/node-fetch.js +++ b/src/node-fallbacks/node-fetch.js @@ -70,7 +70,6 @@ export default Object.assign(fetch, { fileFrom, fileFromSync, isRedirect, - [Symbol.for("CommonJS")]: 0, }); export { -- cgit v1.2.3 From fec0d15c4f20c053c4660ec8ad4da31d689ec895 Mon Sep 17 00:00:00 2001 From: dave caruso Date: Thu, 29 Jun 2023 11:53:44 -0400 Subject: cant believe i missed this (#3453) --- src/node-fallbacks/node-fetch.js | 1 + test/js/node/fs/node-fetch.cjs.test.js | 13 +++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 test/js/node/fs/node-fetch.cjs.test.js (limited to 'src/node-fallbacks/node-fetch.js') diff --git a/src/node-fallbacks/node-fetch.js b/src/node-fallbacks/node-fetch.js index a66d8fc7f..f124e6461 100644 --- a/src/node-fallbacks/node-fetch.js +++ b/src/node-fallbacks/node-fetch.js @@ -70,6 +70,7 @@ export default Object.assign(fetch, { fileFrom, fileFromSync, isRedirect, + [Symbol.for("CommonJS")]: 0, }); export { diff --git a/test/js/node/fs/node-fetch.cjs.test.js b/test/js/node/fs/node-fetch.cjs.test.js new file mode 100644 index 000000000..9a6a4b407 --- /dev/null +++ b/test/js/node/fs/node-fetch.cjs.test.js @@ -0,0 +1,13 @@ +const fetch = require("node-fetch"); + +test("require('node-fetch') fetches", async () => { + const server = Bun.serve({ + port: 0, + fetch(req, server) { + server.stop(); + return new Response(); + }, + }); + expect(await fetch("http://" + server.hostname + ":" + server.port)).toBeInstanceOf(Response); + server.stop(true); +}); -- cgit v1.2.3 From abe095dd1e0962e3510596ccb8c66e0695947c3a Mon Sep 17 00:00:00 2001 From: Dylan Conway <35280289+dylan-conway@users.noreply.github.com> Date: Thu, 6 Jul 2023 13:55:00 -0700 Subject: fixes #3544 (#3549) --- src/node-fallbacks/node-fetch.js | 1 + 1 file changed, 1 insertion(+) (limited to 'src/node-fallbacks/node-fetch.js') diff --git a/src/node-fallbacks/node-fetch.js b/src/node-fallbacks/node-fetch.js index f124e6461..c65d4f6ed 100644 --- a/src/node-fallbacks/node-fetch.js +++ b/src/node-fallbacks/node-fetch.js @@ -70,6 +70,7 @@ export default Object.assign(fetch, { fileFrom, fileFromSync, isRedirect, + default: fetch, [Symbol.for("CommonJS")]: 0, }); -- cgit v1.2.3