From 8e86d2cf1d145fc89d8ef24a646a71ce4214453e Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Tue, 21 Sep 2021 14:40:19 -0700 Subject: Add comment explaining failed package.json parsing optimization --- src/resolver/package_json.zig | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/resolver/package_json.zig') diff --git a/src/resolver/package_json.zig b/src/resolver/package_json.zig index 00b736eba..90a9392f6 100644 --- a/src/resolver/package_json.zig +++ b/src/resolver/package_json.zig @@ -479,6 +479,11 @@ pub const PackageJSON = struct { .main_fields = MainFieldMap.init(r.allocator), }; + // Note: we tried rewriting this to be fewer loops over all the properties (asProperty loops over each) + // The end result was: it's not faster! Sometimes, it's slower. + // It's hard to say why. + // Feels like a codegen issue. + // or that looping over every property doesn't really matter because most package.jsons are < 20 properties if (json.asProperty("version")) |version_json| { if (version_json.expr.asString(r.allocator)) |version_str| { if (version_str.len > 0) { -- cgit v1.2.3 e='astro-request-rfc-old'>astro-request-rfc-old Unnamed repository; edit this file 'description' to name the repository.
aboutsummaryrefslogtreecommitdiff
path: root/examples/framework-lit (unfollow)
AgeCommit message (Expand)AuthorFilesLines
2021-11-19Fix blog example (#1910)Gravatar Matthew Phillips 1-1/+1
2021-11-19Version Packages (next) (#1907)astro@0.21.0-next.10Gravatar github-actions[bot] 23-21/+28
2021-11-19Remove further dependence on vite package (#1906)Gravatar Matthew Phillips 3-5/+9
2021-11-19Version Packages (next) (#1904)astro@0.21.0-next.9Gravatar github-actions[bot] 23-21/+30
2021-11-19Remove OSX \x00 workaround (#1901)Gravatar Matthew Phillips 2-5/+5
2021-11-19Resolve vite client modules to vendored vite (#1903)Gravatar Matthew Phillips 2-2/+7
2021-11-19[ci] yarn formatGravatar matthewp 1-3/+3
2021-11-19Add Debug tests (#1882)Gravatar Matthew Phillips 4-0/+62
2021-11-19[ci] collect statsGravatar FredKSchott 1-0/+1
2021-11-19Version Packages (next) (#1881)astro@0.21.0-next.8@astrojs/renderer-vue@0.2.0-next.2Gravatar github-actions[bot] 25-23/+42
2021-11-18Improve HMR (#1896)Gravatar Drew Powers 2-10/+18
2021-11-18update depsGravatar Fred K. Schott 5-352/+65
2021-11-18fix #1778Gravatar Fred K. Schott 2-1/+8
2021-11-18Update compiler (#1869)Gravatar Nate Moore 3-11/+6
2021-11-18remove unused remark dependency (#1894)Gravatar Fred K. Schott 2-245/+13
2021-11-18Improve error messages (#1875)Gravatar Drew Powers 39-61/+448
2021-11-18pin astro compiler to older versionGravatar Fred K. Schott 2-5/+5
2021-11-18Update yarn.lock to reflect the state of the package.json files (#1892)Gravatar Jonathan Neal 5-1300/+1000
2021-11-19[ci] yarn formatGravatar FredKSchott 1-5/+3