From 8e86d2cf1d145fc89d8ef24a646a71ce4214453e Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Tue, 21 Sep 2021 14:40:19 -0700 Subject: Add comment explaining failed package.json parsing optimization --- src/resolver/package_json.zig | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/resolver/package_json.zig') diff --git a/src/resolver/package_json.zig b/src/resolver/package_json.zig index 00b736eba..90a9392f6 100644 --- a/src/resolver/package_json.zig +++ b/src/resolver/package_json.zig @@ -479,6 +479,11 @@ pub const PackageJSON = struct { .main_fields = MainFieldMap.init(r.allocator), }; + // Note: we tried rewriting this to be fewer loops over all the properties (asProperty loops over each) + // The end result was: it's not faster! Sometimes, it's slower. + // It's hard to say why. + // Feels like a codegen issue. + // or that looping over every property doesn't really matter because most package.jsons are < 20 properties if (json.asProperty("version")) |version_json| { if (version_json.expr.asString(r.allocator)) |version_str| { if (version_str.len > 0) { -- cgit v1.2.3