From 0a318ecca14ab1e71aa60ae8eadbd16343b3a3ea Mon Sep 17 00:00:00 2001 From: MrPalixir <73360179+coratgerl@users.noreply.github.com> Date: Sun, 17 Sep 2023 03:51:18 +0200 Subject: fix: node compatibility with empty path string (#4693) Co-authored-by: MrPalixir <73360179+MrPalixir@users.noreply.github.com> --- src/bun.js/node/types.zig | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/bun.js/node/types.zig b/src/bun.js/node/types.zig index 84dc394d0..72f1dff7e 100644 --- a/src/bun.js/node/types.zig +++ b/src/bun.js/node/types.zig @@ -881,11 +881,7 @@ pub const Valid = struct { pub fn pathSlice(zig_str: JSC.ZigString.Slice, ctx: JSC.C.JSContextRef, exception: JSC.C.ExceptionRef) bool { switch (zig_str.len) { - 0 => { - JSC.throwInvalidArguments("Invalid path string: can't be empty", .{}, ctx, exception); - return false; - }, - 1...bun.MAX_PATH_BYTES => return true, + 0...bun.MAX_PATH_BYTES => return true, else => { // TODO: should this be an EINVAL? JSC.throwInvalidArguments( @@ -903,11 +899,7 @@ pub const Valid = struct { pub fn pathStringLength(len: usize, ctx: JSC.C.JSContextRef, exception: JSC.C.ExceptionRef) bool { switch (len) { - 0 => { - JSC.throwInvalidArguments("Invalid path string: can't be empty", .{}, ctx, exception); - return false; - }, - 1...bun.MAX_PATH_BYTES => return true, + 0...bun.MAX_PATH_BYTES => return true, else => { // TODO: should this be an EINVAL? JSC.throwInvalidArguments( -- cgit v1.2.3