From 79c0b614ee04d06d9565cd52450b0de1f58fa87e Mon Sep 17 00:00:00 2001
From: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
Date: Mon, 23 Jan 2023 15:59:45 -0800
Subject: fix child process node test hang (#1884)
* fix test hang from skipped tests
* add error target
---
src/bun.js/child_process.exports.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
(limited to 'src')
diff --git a/src/bun.js/child_process.exports.js b/src/bun.js/child_process.exports.js
index 7af8bdebd..71d97366a 100644
--- a/src/bun.js/child_process.exports.js
+++ b/src/bun.js/child_process.exports.js
@@ -290,7 +290,9 @@ export function execFile(file, args, options, callback) {
if (args?.length) cmd += ` ${ArrayPrototypeJoin.call(args, " ")}`;
if (!ex) {
- ex = genericNodeError(`Command failed: ${cmd}\n${stderr}`, {
+ let message = `Command failed: ${cmd}`;
+ if (stderr) message += `\n${stderr}`;
+ ex = genericNodeError(message, {
// code: code < 0 ? getSystemErrorName(code) : code, // TODO: Add getSystemErrorName
code: code,
killed: child.killed || killed,
--
cgit v1.2.3
ion value='ciro/child-process-fixes'>ciro/child-process-fixes
| Unnamed repository; edit this file 'description' to name the repository. | |
| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Jarred Sumner