From 4f8edb825f48d06891de7a77131c6a434c06df88 Mon Sep 17 00:00:00 2001 From: dave caruso Date: Wed, 13 Sep 2023 19:57:59 -0400 Subject: fix(runtime): require cache should not include unevaluated ESM modules. (#5233) --- test/cli/run/require-cache-bug-5188.js | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 test/cli/run/require-cache-bug-5188.js (limited to 'test/cli/run/require-cache-bug-5188.js') diff --git a/test/cli/run/require-cache-bug-5188.js b/test/cli/run/require-cache-bug-5188.js new file mode 100644 index 000000000..cb9bd2099 --- /dev/null +++ b/test/cli/run/require-cache-bug-5188.js @@ -0,0 +1,21 @@ +const { strictEqual, ok } = require("assert"); + +Loader.registry.set("bad", { evaluated: false }); +strictEqual(require.cache.bad, undefined); +ok(!Object.hasOwn(require.cache, "bad")); +ok(!Object.getOwnPropertyNames(require.cache).includes("bad")); + +// hard to simplify this test case, but importing this would cause require.cache.extract to be set +require("msgpackr-extract"); + +strictEqual(require.cache["extract"], undefined); +ok(!Object.hasOwnProperty.call(require.cache, "extract")); +ok(!Object.getOwnPropertyNames(require.cache).includes("extract")); + +for (const key of Object.keys(require.cache)) { + if (!require.cache[key]) { + throw new Error("require.cache has an undefined value that was in it's keys"); + } +} + +console.log("--pass--"); -- cgit v1.2.3