From 63e2d78e76d2af1e584b91f013011db8034fae2e Mon Sep 17 00:00:00 2001
From: Ciro Spaciari <ciro.spaciari@gmail.com>
Date: Sun, 28 May 2023 17:20:32 -0300
Subject: [node:net] fix createConnection options passing (#3101)

* fixup createConnection

* fix comment

* fixup comment

* also fix it on tls
---
 test/js/node/net/node-net.test.ts | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

(limited to 'test/js/node/net/node-net.test.ts')

diff --git a/test/js/node/net/node-net.test.ts b/test/js/node/net/node-net.test.ts
index cccada5c0..c38a4ac1a 100644
--- a/test/js/node/net/node-net.test.ts
+++ b/test/js/node/net/node-net.test.ts
@@ -1,6 +1,6 @@
 import { ServerWebSocket, TCPSocket, Socket as _BunSocket, TCPSocketListener } from "bun";
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it } from "bun:test";
-import { connect, isIP, isIPv4, isIPv6, Socket } from "net";
+import { connect, isIP, isIPv4, isIPv6, Socket, createConnection } from "net";
 import { realpathSync, mkdtempSync } from "fs";
 import { tmpdir } from "os";
 import { join } from "path";
@@ -177,6 +177,31 @@ describe("net.Socket read", () => {
         }),
       );
 
+      it(
+        "should work with .createConnection(path)",
+        runWithServer((server, drain, done) => {
+          var data = "";
+          const socket = createConnection(server.unix)
+            .on("connect", () => {
+              expect(socket).toBeDefined();
+              expect(socket.connecting).toBe(false);
+            })
+            .setEncoding("utf8")
+            .on("data", chunk => {
+              data += chunk;
+            })
+            .on("end", () => {
+              try {
+                expect(data).toBe(message);
+                done();
+              } catch (e) {
+                server.stop();
+                done(e);
+              }
+            })
+            .on("error", done);
+        }, socket_domain),
+      );
       it(
         "should work with .connect(path)",
         runWithServer((server, drain, done) => {
-- 
cgit v1.2.3