diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-12-01 13:21:18 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-12-01 13:21:18 +0000 |
| commit | 0d103ff57ca1b65ec9610b6992e14277e685eb70 (patch) | |
| tree | b8c49022151575af5af70422f34e40fa601151d5 | |
| parent | 861e2382c2463366ac576d556f52f8e8d6a3770c (diff) | |
| download | coredns-0d103ff57ca1b65ec9610b6992e14277e685eb70.tar.gz coredns-0d103ff57ca1b65ec9610b6992e14277e685eb70.tar.zst coredns-0d103ff57ca1b65ec9610b6992e14277e685eb70.zip | |
plugin/proxy: add note about HC and google_https (#1269)
HC for google_https does not work because it does not HC the correct
set of IPs. Hard to solve in the current code - rather use forward as
the new impl. and leave this as legacy.
Remove superfluous println that we are refreshing the dns.google.com IP
address.
| -rw-r--r-- | plugin/proxy/README.md | 5 | ||||
| -rw-r--r-- | plugin/proxy/google.go | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/plugin/proxy/README.md b/plugin/proxy/README.md index 3240413c0..04a9826e2 100644 --- a/plugin/proxy/README.md +++ b/plugin/proxy/README.md @@ -188,3 +188,8 @@ example.org { proxy . 8.8.8.8:53 } ~~~ + +# Bugs + +When using the `google_https` protocol the health checking will health check the wrong endpoint. +See <https://github.com/coredns/coredns/issues/1202> for some background. diff --git a/plugin/proxy/google.go b/plugin/proxy/google.go index f635fc500..cc91c60ec 100644 --- a/plugin/proxy/google.go +++ b/plugin/proxy/google.go @@ -117,8 +117,6 @@ func (g *google) OnStartup(p *Proxy) error { oldUpstream := (*p.Upstreams)[0] - log.Printf("[INFO] Bootstrapping A records %q", g.endpoint) - new, err := g.bootstrapProxy.Lookup(state, g.endpoint, dns.TypeA) if err != nil { log.Printf("[WARNING] Failed to bootstrap A records %q: %s", g.endpoint, err) |