diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-02-09 11:30:55 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-02-09 11:30:55 +0000 |
| commit | 2e894eb0a27f5c7d5479c32db69a461e4ed544c8 (patch) | |
| tree | 2ffd73cb37fec47b81313e348ad4d1625b27acd1 | |
| parent | 006ce4d56e394f08cb5c1a296d6e0526165d209a (diff) | |
| download | coredns-2e894eb0a27f5c7d5479c32db69a461e4ed544c8.tar.gz coredns-2e894eb0a27f5c7d5479c32db69a461e4ed544c8.tar.zst coredns-2e894eb0a27f5c7d5479c32db69a461e4ed544c8.zip | |
plugin/reload: disable for now (#1511)
Reloading should work (kill -TERM reload the coredns process), but a lot
of plugins can't handle it proper. Disable to reload plugin until we fix
(most) of the plugins
| -rw-r--r-- | core/dnsserver/zdirectives.go | 1 | ||||
| -rw-r--r-- | core/plugin/zplugin.go | 1 | ||||
| -rw-r--r-- | plugin.cfg | 2 | ||||
| -rw-r--r-- | plugin/reload/README.md | 4 |
4 files changed, 3 insertions, 5 deletions
diff --git a/core/dnsserver/zdirectives.go b/core/dnsserver/zdirectives.go index f0017e82c..ba8873936 100644 --- a/core/dnsserver/zdirectives.go +++ b/core/dnsserver/zdirectives.go @@ -11,7 +11,6 @@ package dnsserver // care what plugin above them are doing. var Directives = []string{ "tls", - "reload", "nsid", "root", "bind", diff --git a/core/plugin/zplugin.go b/core/plugin/zplugin.go index 75fb797a4..0de47374a 100644 --- a/core/plugin/zplugin.go +++ b/core/plugin/zplugin.go @@ -27,7 +27,6 @@ import ( _ "github.com/coredns/coredns/plugin/nsid" _ "github.com/coredns/coredns/plugin/pprof" _ "github.com/coredns/coredns/plugin/proxy" - _ "github.com/coredns/coredns/plugin/reload" _ "github.com/coredns/coredns/plugin/reverse" _ "github.com/coredns/coredns/plugin/rewrite" _ "github.com/coredns/coredns/plugin/root" diff --git a/plugin.cfg b/plugin.cfg index 60193990d..21da3b949 100644 --- a/plugin.cfg +++ b/plugin.cfg @@ -20,7 +20,7 @@ # log:log tls:tls -reload:reload +#reload:reload # enable by reverting #1511 nsid:nsid root:root bind:bind diff --git a/plugin/reload/README.md b/plugin/reload/README.md index 1f7f572ad..98c7fd502 100644 --- a/plugin/reload/README.md +++ b/plugin/reload/README.md @@ -42,7 +42,7 @@ reload [INTERVAL] [JITTER] Check with the default intervals: -~~~ corefile +~~~ txt . { reload erratic @@ -51,7 +51,7 @@ Check with the default intervals: Check every 10 seconds (jitter is automatically set to 10 / 2 = 5 in this case): -~~~ corefile +~~~ txt . { reload 10s erratic |