aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Johnny Bergström <github@joonix.se> 2020-10-06 15:38:12 +0200
committerGravatar GitHub <noreply@github.com> 2020-10-06 15:38:12 +0200
commit383cc2809b11ed504fde10fee6b28e000ac0268e (patch)
tree1d9eff4bd9aee45f002c0df2b9e04d1b872cf020
parentf2ec292e463267dbbe6ce61cddd260921dfc93e3 (diff)
downloadcoredns-383cc2809b11ed504fde10fee6b28e000ac0268e.tar.gz
coredns-383cc2809b11ed504fde10fee6b28e000ac0268e.tar.zst
coredns-383cc2809b11ed504fde10fee6b28e000ac0268e.zip
fix alpn for http/2 upgrade when using DoH (#4182)
Signed-off-by: Johnny Bergström <johnny@klaudify.se>
-rw-r--r--core/dnsserver/server_https.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/core/dnsserver/server_https.go b/core/dnsserver/server_https.go
index fb5933815..27757861c 100644
--- a/core/dnsserver/server_https.go
+++ b/core/dnsserver/server_https.go
@@ -41,6 +41,9 @@ func NewServerHTTPS(addr string, group []*Config) (*ServerHTTPS, error) {
if tlsConfig == nil {
return nil, fmt.Errorf("DoH requires TLS to be configured, see the tls plugin")
}
+ // http/2 is recommended when using DoH. We need to specify it in next protos
+ // or the upgrade won't happen.
+ tlsConfig.NextProtos = []string{"h2", "http/1.1"}
srv := &http.Server{
ReadTimeout: 5 * time.Second,