diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-07-27 15:01:27 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-07-27 15:01:27 +0100 |
| commit | 395be9adfc07017d8dc9a8c260aed2541b4adda3 (patch) | |
| tree | 407a9bcf5205b6234ec068ac43fda834004bc778 | |
| parent | bcf00be3fb6962acce3a04e05c9999e3e6f461c6 (diff) | |
| download | coredns-395be9adfc07017d8dc9a8c260aed2541b4adda3.tar.gz coredns-395be9adfc07017d8dc9a8c260aed2541b4adda3.tar.zst coredns-395be9adfc07017d8dc9a8c260aed2541b4adda3.zip | |
Makefile: remove goimports (#2008)
This downloads gometalinter (which is now breaking in the CI tests).
Also the goimports target is run with ||true, so nothing will break
if this flags anything (done because of gofmt changes in between
release).
Probably I will setup something to use github's linter API:
https://github.com/markstory/lint-review
Signed-off-by: Miek Gieben <miek@miek.nl>
| -rw-r--r-- | Makefile | 8 |
1 files changed, 1 insertions, 7 deletions
@@ -15,7 +15,7 @@ coredns: $(CHECKS) CGO_ENABLED=0 $(SYSTEM) go build $(VERBOSE) -ldflags="-s -w -X github.com/coredns/coredns/coremain.GitCommit=$(GITCOMMIT)" -o $(BINARY) .PHONY: check -check: presubmit goimports core/zplugin.go core/dnsserver/zdirectives.go godeps +check: presubmit core/zplugin.go core/dnsserver/zdirectives.go godeps .PHONY: test test: check @@ -78,12 +78,6 @@ gen: pb: $(MAKE) -C pb -.PHONY: goimports -goimports: - go get -u github.com/alecthomas/gometalinter - gometalinter --install goimports > /dev/null - ( gometalinter --deadline=2m --disable-all --enable=goimports --enable=golint --enable=vet --vendor --exclude=^pb/ ./... || true ) - # Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build. .PHONY: presubmit presubmit: |