aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Euan Kemp <euank@euank.com> 2019-10-29 06:38:56 -0700
committerGravatar Chris O'Haver <cohaver@infoblox.com> 2019-10-29 09:38:56 -0400
commit431c70e8b965545f16fa7afdc025787aec014241 (patch)
treef561a379294938320d5b24f3798c75a6ff36657c
parent1821d9cb7e77fb9cdc8b90f46171d7c16b14e37c (diff)
downloadcoredns-431c70e8b965545f16fa7afdc025787aec014241.tar.gz
coredns-431c70e8b965545f16fa7afdc025787aec014241.tar.zst
coredns-431c70e8b965545f16fa7afdc025787aec014241.zip
Correct some if/iff mixups (#3406)
This is a fixup for https://github.com/coredns/coredns/pull/3310 which replaced some 'iff's with 'if' under the assumption they were typos. I'm fairly confident they were "If and only if" (https://en.wikipedia.org/wiki/If_and_only_if), which is commonly shortened as "iff". I've updated them to the full length 'if, and only if' for the sake of readability. Signed-off-by: Euan Kemp <euan@ngrok.com>
-rw-r--r--plugin/autopath/autopath.go2
-rw-r--r--plugin/dnssec/dnskey.go4
2 files changed, 3 insertions, 3 deletions
diff --git a/plugin/autopath/autopath.go b/plugin/autopath/autopath.go
index 8583988d9..4db9366d2 100644
--- a/plugin/autopath/autopath.go
+++ b/plugin/autopath/autopath.go
@@ -5,7 +5,7 @@ client's search path resolution by performing these lookups on the server...
The server has a copy (via AutoPathFunc) of the client's search path and on
receiving a query it first establishes if the suffix matches the FIRST configured
element. If no match can be found the query will be forwarded up the plugin
-chain without interference (if 'fallthrough' has been set).
+chain without interference (if, and only if, 'fallthrough' has been set).
If the query is deemed to fall in the search path the server will perform the
queries with each element of the search path appended in sequence until a
diff --git a/plugin/dnssec/dnskey.go b/plugin/dnssec/dnskey.go
index 5c67fca08..6ca89802e 100644
--- a/plugin/dnssec/dnskey.go
+++ b/plugin/dnssec/dnskey.go
@@ -83,12 +83,12 @@ func (d Dnssec) getDNSKEY(state request.Request, zone string, do bool, server st
return m
}
-// Return true if this is a zone key with the SEP bit unset. This implies a ZSK (rfc4034 2.1.1).
+// Return true if, and only if, this is a zone key with the SEP bit unset. This implies a ZSK (rfc4034 2.1.1).
func (k DNSKEY) isZSK() bool {
return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 0
}
-// Return true if this is a zone key with the SEP bit set. This implies a KSK (rfc4034 2.1.1).
+// Return true if, and only if, this is a zone key with the SEP bit set. This implies a KSK (rfc4034 2.1.1).
func (k DNSKEY) isKSK() bool {
return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 1
}