diff options
| author |  Darshan Chaudhary <deathbullet@gmail.com>
| 2019-02-23 22:32:58 +0530 |
|---|---|---|
| committer |  Yong Tang <yong.tang.github@outlook.com>
| 2019-02-23 09:02:58 -0800 |
| commit | 70fcbbf6ba073eb408b94b1fa06c8dca839efd37 (patch) | |
| tree | 78eb8e6f21150c55be2b780f8f7f98a9ab527b33 | |
| parent | 92b71366846e2f4318d3214591116cfc9f6e04d1 (diff) | |
| download | coredns-70fcbbf6ba073eb408b94b1fa06c8dca839efd37.tar.gz coredns-70fcbbf6ba073eb408b94b1fa06c8dca839efd37.tar.zst coredns-70fcbbf6ba073eb408b94b1fa06c8dca839efd37.zip | |
refactor tests to remove duplicate code (#2602)
Signed-off-by: darshanime <deathbullet@gmail.com>
| -rw-r--r-- | plugin/route53/setup_test.go | 118 |
1 files changed, 38 insertions, 80 deletions
diff --git a/plugin/route53/setup_test.go b/plugin/route53/setup_test.go index 99310dce4..4f40d932f 100644 --- a/plugin/route53/setup_test.go +++ b/plugin/route53/setup_test.go @@ -13,106 +13,64 @@ func TestSetupRoute53(t *testing.T) { return fakeRoute53{} } - c := caddy.NewTestController("dns", `route53`) - if err := setup(c, f); err != nil { - t.Fatalf("Expected no errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 :`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678`) - if err := setup(c, f); err != nil { - t.Fatalf("Expected no errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + tests := []struct { + body string + expectedError bool + }{ + {`route53`, false}, + {`route53 :`, true}, + {`route53 example.org:12345678`, false}, + {`route53 example.org:12345678 { aws_access_key -}`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { +}`, true}, + {`route53 example.org:12345678 { upstream 10.0.0.1 -}`) - if err := setup(c, f); err != nil { - t.Fatalf("Expected no errors, but got: %v", err) - } +}`, false}, - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + {`route53 example.org:12345678 { upstream -}`) - if err := setup(c, f); err != nil { - t.Fatalf("Expected no errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { +}`, false}, + {`route53 example.org:12345678 { wat -}`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { +}`, true}, + {`route53 example.org:12345678 { aws_access_key ACCESS_KEY_ID SEKRIT_ACCESS_KEY upstream 1.2.3.4 -}`) - if err := setup(c, f); err != nil { - t.Fatalf("Unexpected errors: %v", err) - } +}`, false}, - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + {`route53 example.org:12345678 { fallthrough -}`) - if err := setup(c, f); err != nil { - t.Fatalf("Unexpected errors: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { +}`, false}, + {`route53 example.org:12345678 { credentials upstream 1.2.3.4 - }`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) - } + }`, true}, - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + {`route53 example.org:12345678 { credentials default upstream 1.2.3.4 - }`) - if err := setup(c, f); err != nil { - t.Fatalf("Unexpected errors: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + }`, false}, + {`route53 example.org:12345678 { credentials default credentials upstream 1.2.3.4 - }`) - if err := setup(c, f); err != nil { - t.Fatalf("Unexpected errors: %v", err) - } - - c = caddy.NewTestController("dns", `route53 example.org:12345678 { + }`, false}, + {`route53 example.org:12345678 { credentials default credentials extra-arg upstream 1.2.3.4 - }`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) - } + }`, true}, + {`route53 example.org:12345678 example.org:12345678 { + upstream 1.2.3.4 + }`, true}, - c = caddy.NewTestController("dns", `route53 example.org:12345678 example.org:12345678 { + {`route53 example.org { upstream 1.2.3.4 - }`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) + }`, true}, } - c = caddy.NewTestController("dns", `route53 example.org { - upstream 1.2.3.4 - }`) - if err := setup(c, f); err == nil { - t.Fatalf("Expected errors, but got: %v", err) + + for _, test := range tests { + c := caddy.NewTestController("dns", test.body) + if err := setup(c, f); (err == nil) == test.expectedError { + t.Errorf("Unexpected errors: %v", err) + } } } |