aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2017-01-22 03:15:12 -0500
committerGravatar Miek Gieben <miek@miek.nl> 2017-01-22 08:15:12 +0000
commita1215974ee852ff7e1bbc20481332f7c70eee765 (patch)
tree9236e04a21009d9cde1d6b57873fbade1ccd730f
parent166c822d91432cb0b06afaad9440678d3bf9e39d (diff)
downloadcoredns-a1215974ee852ff7e1bbc20481332f7c70eee765.tar.gz
coredns-a1215974ee852ff7e1bbc20481332f7c70eee765.tar.zst
coredns-a1215974ee852ff7e1bbc20481332f7c70eee765.zip
only a * by itself is wild (#488)
-rw-r--r--middleware/kubernetes/kubernetes.go2
-rw-r--r--middleware/kubernetes/kubernetes_test.go6
2 files changed, 4 insertions, 4 deletions
diff --git a/middleware/kubernetes/kubernetes.go b/middleware/kubernetes/kubernetes.go
index c59f98835..0d8c68976 100644
--- a/middleware/kubernetes/kubernetes.go
+++ b/middleware/kubernetes/kubernetes.go
@@ -529,5 +529,5 @@ func (k *Kubernetes) getServiceRecordForIP(ip, name string) []msg.Service {
// symbolContainsWildcard checks whether symbol contains a wildcard value
func symbolContainsWildcard(symbol string) bool {
- return (strings.Contains(symbol, "*") || (symbol == "any"))
+ return (symbol == "*" || symbol == "any")
}
diff --git a/middleware/kubernetes/kubernetes_test.go b/middleware/kubernetes/kubernetes_test.go
index f7529a1d5..7b59cfecf 100644
--- a/middleware/kubernetes/kubernetes_test.go
+++ b/middleware/kubernetes/kubernetes_test.go
@@ -11,9 +11,9 @@ var testdataSymbolContainsWildcard = []struct {
{"mynamespace", false},
{"*", true},
{"any", true},
- {"my*space", true},
- {"*space", true},
- {"myname*", true},
+ {"my*space", false},
+ {"*space", false},
+ {"myname*", false},
}
func TestSymbolContainsWildcard(t *testing.T) {