diff options
| author |  Miek Gieben <miek@miek.nl>
| 2019-07-31 18:18:49 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2019-07-31 18:18:49 +0000 |
| commit | cd5dcebe9352b6a08687cfdf3ac8115bd7c8dfcc (patch) | |
| tree | a02b24729cf9f49cad97428560dcb09fbd1fdc22 | |
| parent | 7be2226eab684c18b74c5c28db8de9335560ffc3 (diff) | |
| download | coredns-cd5dcebe9352b6a08687cfdf3ac8115bd7c8dfcc.tar.gz coredns-cd5dcebe9352b6a08687cfdf3ac8115bd7c8dfcc.tar.zst coredns-cd5dcebe9352b6a08687cfdf3ac8115bd7c8dfcc.zip | |
core: log panics (#3072)
These are too hidden now. They increase the issue-load, because people
don't see them.
Add log.Errorf in the core/dnsserver recover routine.
Signed-off-by: Miek Gieben <miek@miek.nl>
| -rw-r--r-- | core/dnsserver/server.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/core/dnsserver/server.go b/core/dnsserver/server.go index 558954304..4a143f9b3 100644 --- a/core/dnsserver/server.go +++ b/core/dnsserver/server.go @@ -200,6 +200,7 @@ func (s *Server) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) // In case the user doesn't enable error plugin, we still // need to make sure that we stay alive up here if rec := recover(); rec != nil { + log.Errorf("Recovered from panic in server: %q", s.Addr) vars.Panic.Inc() errorAndMetricsFunc(s.Addr, w, r, dns.RcodeServerFailure) } |