diff options
author | 2016-09-03 09:47:45 +0100 | |
---|---|---|
committer | 2016-09-03 09:47:45 +0100 | |
commit | e750a4c1bde5e173b173a4b2d348d88a61f9caca (patch) | |
tree | 1828a424e9269f201acc9d1b8ad192873751aded | |
parent | ea557b150237712f2751277230ca1817facfa848 (diff) | |
parent | 99170ac62e612ce3478974c7a91dbda1d5a7f78d (diff) | |
download | coredns-e750a4c1bde5e173b173a4b2d348d88a61f9caca.tar.gz coredns-e750a4c1bde5e173b173a4b2d348d88a61f9caca.tar.zst coredns-e750a4c1bde5e173b173a4b2d348d88a61f9caca.zip |
Merge pull request #241 from miekg/nsec3-warn
Better logging for NSEC3
-rw-r--r-- | middleware/file/nsec3_test.go | 18 | ||||
-rw-r--r-- | middleware/file/zone.go | 2 |
2 files changed, 15 insertions, 5 deletions
diff --git a/middleware/file/nsec3_test.go b/middleware/file/nsec3_test.go index 1e1e68700..d9e48921a 100644 --- a/middleware/file/nsec3_test.go +++ b/middleware/file/nsec3_test.go @@ -5,16 +5,26 @@ import ( "testing" ) +func TestParseNSEC3PARAM(t *testing.T) { + _, err := Parse(strings.NewReader(nsec3param_test), "miek.nl", "stdin") + if err == nil { + t.Fatalf("expected error when reading zone, got nothing") + } + t.Logf("%v\n", err) +} + func TestParseNSEC3(t *testing.T) { _, err := Parse(strings.NewReader(nsec3_test), "miek.nl", "stdin") if err == nil { t.Fatalf("expected error when reading zone, got nothing") } + t.Logf("%v\n", err) } -const nsec3_test = `miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1460175181 14400 3600 604800 14400 +const nsec3param_test = `miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1460175181 14400 3600 604800 14400 miek.nl. 1800 IN NS omval.tednet.nl. -miek.nl. 1800 IN NS linode.atoom.net. -miek.nl. 1800 IN NS ext.ns.whyscream.net. -miek.nl. 1800 IN NS ns-ext.nlnetlabs.nl. miek.nl. 0 IN NSEC3PARAM 1 0 5 A3DEBC9CC4F695C7` + +const nsec3_test = `example.org. 1800 IN SOA sns.dns.icann.org. noc.dns.icann.org. 2016082508 7200 3600 1209600 3600 +aub8v9ce95ie18spjubsr058h41n7pa5.example.org. 284 IN NSEC3 1 1 5 D0CBEAAF0AC77314 AUB95P93VPKP55G6U5S4SGS7LS61ND85 NS SOA TXT RRSIG DNSKEY NSEC3PARAM +aub8v9ce95ie18spjubsr058h41n7pa5.example.org. 284 IN RRSIG NSEC3 8 2 600 20160910232502 20160827231002 14028 example.org. XBNpA7KAIjorPbXvTinOHrc1f630aHic2U716GHLHA4QMx9cl9ss4QjR Wj2UpDM9zBW/jNYb1xb0yjQoez/Jv200w0taSWjRci5aUnRpOi9bmcrz STHb6wIUjUsbJ+NstQsUwVkj6679UviF1FqNwr4GlJnWG3ZrhYhE+NI6 s0k=` diff --git a/middleware/file/zone.go b/middleware/file/zone.go index 155d7690c..b84162cbb 100644 --- a/middleware/file/zone.go +++ b/middleware/file/zone.go @@ -74,7 +74,7 @@ func (z *Zone) Insert(r dns.RR) error { z.Apex.SOA = r.(*dns.SOA) return nil case dns.TypeNSEC3, dns.TypeNSEC3PARAM: - return fmt.Errorf("NSEC3 zone is not supported, dropping") + return fmt.Errorf("NSEC3 zone is not supported, dropping RR: %s for zone: %s", r.Header().Name, z.origin) case dns.TypeRRSIG: x := r.(*dns.RRSIG) switch x.TypeCovered { |