diff options
| author |  xuweiwei <xuweiwei_yewu@cmss.chinamobile.com>
| 2021-11-20 00:15:58 +0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-11-19 16:15:58 +0000 |
| commit | 5f900b86f5575ce2be8450057c03ba6f65236f4d (patch) | |
| tree | 0d29e9073bd7f1c19aed2793d961fa4e1533b165 | |
| parent | c707a4e7c6d231306f182ff3ee7374266ed2c346 (diff) | |
| download | coredns-5f900b86f5575ce2be8450057c03ba6f65236f4d.tar.gz coredns-5f900b86f5575ce2be8450057c03ba6f65236f4d.tar.zst coredns-5f900b86f5575ce2be8450057c03ba6f65236f4d.zip | |
cleanup some code (#4989)
Automatically submitted.
| -rw-r--r-- | plugin/cache/dnssec.go | 2 | ||||
| -rw-r--r-- | plugin/clouddns/gcp.go | 4 | ||||
| -rw-r--r-- | plugin/kubernetes/namespace.go | 5 |
3 files changed, 3 insertions, 8 deletions
diff --git a/plugin/cache/dnssec.go b/plugin/cache/dnssec.go index 61a1cc15f..cf908037e 100644 --- a/plugin/cache/dnssec.go +++ b/plugin/cache/dnssec.go @@ -26,7 +26,7 @@ func isDNSSEC(r dns.RR) bool { // returned. func filterRRSlice(rrs []dns.RR, ttl uint32, do, dup bool) []dns.RR { j := 0 - rs := make([]dns.RR, len(rrs), len(rrs)) + rs := make([]dns.RR, len(rrs)) for _, r := range rrs { if !do && isDNSSEC(r) { continue diff --git a/plugin/clouddns/gcp.go b/plugin/clouddns/gcp.go index 0f5126c87..b02ab2bda 100644 --- a/plugin/clouddns/gcp.go +++ b/plugin/clouddns/gcp.go @@ -31,9 +31,7 @@ func (c gcpClient) listRRSets(ctx context.Context, projectName, hostedZoneName s req := c.ResourceRecordSets.List(projectName, hostedZoneName) var rs []*gcp.ResourceRecordSet if err := req.Pages(ctx, func(page *gcp.ResourceRecordSetsListResponse) error { - for _, rr := range page.Rrsets { - rs = append(rs, rr) - } + rs = append(rs, page.Rrsets...) return nil }); err != nil { return nil, err diff --git a/plugin/kubernetes/namespace.go b/plugin/kubernetes/namespace.go index 4dcc3afa4..3e90bab7c 100644 --- a/plugin/kubernetes/namespace.go +++ b/plugin/kubernetes/namespace.go @@ -6,10 +6,7 @@ package kubernetes // see namespaceExposed. func (k *Kubernetes) filteredNamespaceExists(namespace string) bool { _, err := k.APIConn.GetNamespaceByName(namespace) - if err != nil { - return false - } - return true + return err == nil } // configuredNamespace returns true when the namespace is exposed through the plugin |