aboutsummaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorGravatar Yong Tang <yong.tang.github@outlook.com> 2019-07-25 13:20:23 -0700
committerGravatar GitHub <noreply@github.com> 2019-07-25 13:20:23 -0700
commitee6c5f87d1ef5a00cf4383946ef6b98fe3d9a0db (patch)
treee5d760c4e138d0c26e4f78fdf121b95f515c0469 /CONTRIBUTING.md
parent89fa9bc61e1347c26ebfa87dc789673d049294f9 (diff)
downloadcoredns-ee6c5f87d1ef5a00cf4383946ef6b98fe3d9a0db.tar.gz
coredns-ee6c5f87d1ef5a00cf4383946ef6b98fe3d9a0db.tar.zst
coredns-ee6c5f87d1ef5a00cf4383946ef6b98fe3d9a0db.zip
Update CONTRIBUTING.md (#3046)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md6
1 files changed, 5 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index bb3801347..18bd4a62b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -29,11 +29,15 @@ tests to assert your change is working properly and is thoroughly covered.
First, please [search](https://github.com/coredns/coredns/search?q=&type=Issues&utf8=%E2%9C%93) with
a variety of keywords to ensure your suggestion/proposal is new.
-If so, you may open either an issue or a pull request for discussion and feedback.
+Please also check for existing pull requests to see if someone is already working on this. We want to avoid duplication of effort.
+
+If the proposal is new and no one has opened pull request yet, you may open either an issue or a pull request for discussion and feedback.
If you are going to spend significant time implementing code for a pull request, best to open an
issue first and "claim" it and get feedback before you invest a lot of time.
+**If someone already opened a pull request, but you think the pull request has stalled and you would like to open another pull request for the same or similar feature, get some of the maintainers (see [OWNERS](OWNERS)) involved to resolve the situation and move things forward.**
+
If possible make a pull request as small as possible, or submit multiple pull request to complete a
feature. Smaller means: easier to understand and review. This in turn means things can be merged
faster.