diff options
| author |  Yong Tang <yong.tang.github@outlook.com>
| 2018-05-19 15:03:32 -0700 |
|---|---|---|
| committer |  Miek Gieben <miek@miek.nl>
| 2018-05-19 23:03:32 +0100 |
| commit | a40345d65fa5925d10ce38ea61a7256e6ba7a89b (patch) | |
| tree | 48371782e63c772eeefced02a79e034a289d6b4f /Makefile | |
| parent | 7ac507d9ffd19e03737345408b62a732ec706c73 (diff) | |
| download | coredns-a40345d65fa5925d10ce38ea61a7256e6ba7a89b.tar.gz coredns-a40345d65fa5925d10ce38ea61a7256e6ba7a89b.tar.zst coredns-a40345d65fa5925d10ce38ea61a7256e6ba7a89b.zip | |
Fix `make check` dependency error (#1818)
While invoking `make check` from a fresh new environment
the following failure occured:
```
[ec2-user@..... coredns]$ docker run -i -t --rm -v $PWD:/go/src/github.com/coredns/coredns -w /go/src/github.com/coredns/coredns golang:1.10
root@e2d6a6c17132:/go/src/github.com/coredns/coredns# make check
** presubmit/context
** presubmit/test-lowercase
( gometalinter --deadline=2m --disable-all --enable=goimports --vendor --exclude=^pb/ ./... || true )
/bin/sh: 1: gometalinter: not found
go generate coredns.go
```
This fix fixes the issue in Makefile so that deps could be installed first.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -85,6 +85,8 @@ linter: .PHONY: goimports goimports: + go get -u github.com/alecthomas/gometalinter + gometalinter --install goimports ( gometalinter --deadline=2m --disable-all --enable=goimports --vendor --exclude=^pb/ ./... || true ) # Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build. |