diff options
| author |  Yong Tang <yongtang@users.noreply.github.com>
| 2017-03-05 14:17:05 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-03-05 14:17:05 -0800 |
| commit | 1e4ba588dc2e1e8b011ffe878977f5a909302bbe (patch) | |
| tree | bda41335f3d2f2ba3d90b3c356b78cc9f518738e /middleware | |
| parent | 5eedb728dfdeebe5284af3760879aa3f054ffdb0 (diff) | |
| download | coredns-1e4ba588dc2e1e8b011ffe878977f5a909302bbe.tar.gz coredns-1e4ba588dc2e1e8b011ffe878977f5a909302bbe.tar.zst coredns-1e4ba588dc2e1e8b011ffe878977f5a909302bbe.zip | |
Enforce `go lint` check and fix several lint issues (#570)
This fix updates the Makefile to add the `go lint` check
for the build. This fix also fixes several go lint issues.
NOTE: This fix does not enforce `go lint` (suggestion only).
This fix also ignores the `go lint` error:
```
middleware/middleware.go:72:1: context.Context should be the first parameter of a function
```
as it requires too many changes in API.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Diffstat (limited to 'middleware')
| -rw-r--r-- | middleware/trace/trace_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/middleware/trace/trace_test.go b/middleware/trace/trace_test.go index 37dec2065..06b2aafcf 100644 --- a/middleware/trace/trace_test.go +++ b/middleware/trace/trace_test.go @@ -6,15 +6,15 @@ import ( "github.com/mholt/caddy" ) -// CreateTestTrace creates a trace middleware to be used in tests -func CreateTestTrace(config string) (*caddy.Controller, *trace, error) { +// createTestTrace creates a trace middleware to be used in tests +func createTestTrace(config string) (*caddy.Controller, *trace, error) { c := caddy.NewTestController("dns", config) m, err := traceParse(c) return c, m, err } func TestTrace(t *testing.T) { - _, m, err := CreateTestTrace(`trace`) + _, m, err := createTestTrace(`trace`) if err != nil { t.Errorf("Error parsing test input: %s", err) return |