diff options
| author |  John Belamaric <jbelamaric@infoblox.com>
| 2017-04-18 11:10:49 -0400 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-04-18 11:10:49 -0400 |
| commit | 5a60090933a221467fdc2e18faa516c6c55be306 (patch) | |
| tree | 9c8c14dbfd8a299a89ad3d2a3f78bff60dd3dcca /middleware | |
| parent | 3b6eab22563e57471b8bce56e3dc8c3ca06c427d (diff) | |
| download | coredns-5a60090933a221467fdc2e18faa516c6c55be306.tar.gz coredns-5a60090933a221467fdc2e18faa516c6c55be306.tar.zst coredns-5a60090933a221467fdc2e18faa516c6c55be306.zip | |
Tracing for gRPC Server (#619)
* Implements tracing in the native gRPC server
* Undo some unnecessary changes
* Properly revert trace/setup.go this time
* Some very very basic tests
* Remove warning for non-Trace middleware
Diffstat (limited to 'middleware')
| -rw-r--r-- | middleware/pkg/trace/trace.go | 12 | ||||
| -rw-r--r-- | middleware/proxy/grpc.go | 2 | ||||
| -rw-r--r-- | middleware/trace/trace.go | 7 |
3 files changed, 14 insertions, 7 deletions
diff --git a/middleware/pkg/trace/trace.go b/middleware/pkg/trace/trace.go new file mode 100644 index 000000000..e4858942b --- /dev/null +++ b/middleware/pkg/trace/trace.go @@ -0,0 +1,12 @@ +package trace + +import ( + "github.com/coredns/coredns/middleware" + ot "github.com/opentracing/opentracing-go" +) + +// Trace holds the tracer and endpoint info +type Trace interface { + middleware.Handler + Tracer() ot.Tracer +} diff --git a/middleware/proxy/grpc.go b/middleware/proxy/grpc.go index d3ed14ccd..031869c60 100644 --- a/middleware/proxy/grpc.go +++ b/middleware/proxy/grpc.go @@ -5,7 +5,7 @@ import ( "crypto/tls" "log" - "github.com/coredns/coredns/middleware/trace" + "github.com/coredns/coredns/middleware/pkg/trace" "github.com/coredns/coredns/pb" "github.com/coredns/coredns/request" diff --git a/middleware/trace/trace.go b/middleware/trace/trace.go index 3413fa681..78089b0e1 100644 --- a/middleware/trace/trace.go +++ b/middleware/trace/trace.go @@ -7,6 +7,7 @@ import ( "sync/atomic" "github.com/coredns/coredns/middleware" + _ "github.com/coredns/coredns/middleware/pkg/trace" "github.com/miekg/dns" ot "github.com/opentracing/opentracing-go" zipkin "github.com/openzipkin/zipkin-go-opentracing" @@ -14,12 +15,6 @@ import ( "golang.org/x/net/context" ) -// Trace holds the tracer and endpoint info -type Trace interface { - middleware.Handler - Tracer() ot.Tracer -} - type trace struct { Next middleware.Handler ServiceEndpoint string |