aboutsummaryrefslogtreecommitdiff
path: root/middleware
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2016-03-19 20:17:44 +0000
committerGravatar Miek Gieben <miek@miek.nl> 2016-03-19 20:17:44 +0000
commitec84cb127092abf14937b5979bdb15ee2814cbeb (patch)
treeed47ccc81ede8c22981f6977bd34e772141208b7 /middleware
parent6f5fe26e1f7105b732ffa4b750c782f9f02175ba (diff)
downloadcoredns-ec84cb127092abf14937b5979bdb15ee2814cbeb.tar.gz
coredns-ec84cb127092abf14937b5979bdb15ee2814cbeb.tar.zst
coredns-ec84cb127092abf14937b5979bdb15ee2814cbeb.zip
Random fixes and make servfail the special return code
Diffstat (limited to 'middleware')
-rw-r--r--middleware/replacer.go8
1 files changed, 6 insertions, 2 deletions
diff --git a/middleware/replacer.go b/middleware/replacer.go
index 2d9f6caa3..9d242fdb9 100644
--- a/middleware/replacer.go
+++ b/middleware/replacer.go
@@ -48,13 +48,17 @@ func NewReplacer(r *dns.Msg, rr *ResponseRecorder, emptyValue string) Replacer {
emptyValue: emptyValue,
}
if rr != nil {
- rep.replacements["{rcode}"] = strconv.Itoa(rr.rcode)
+ rcode := dns.RcodeToString[rr.rcode]
+ if rcode == "" {
+ rcode = strconv.Itoa(rr.rcode)
+ }
+ rep.replacements["{rcode}"] = rcode
rep.replacements["{size}"] = strconv.Itoa(rr.size)
rep.replacements["{latency}"] = time.Since(rr.start).String()
}
// Header placeholders (case-insensitive)
- // TODO(miek): syntax for flags
+ // TODO(miek): syntax for flags and document it
rep.replacements[headerReplacer+"id}"] = strconv.Itoa(int(r.Id))
rep.replacements[headerReplacer+"opcode}"] = strconv.Itoa(int(r.Opcode))