diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-03-02 18:17:05 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-03-02 18:17:05 -0800 |
| commit | acf823cd78d295c4664937ef7ac72b96349a1cf0 (patch) | |
| tree | f1ea279480d0ea6e3a649bd1a4de20666794eebf /pb | |
| parent | 6cec66ce404b8f680cca5d03584ebcbd1ab888e0 (diff) | |
| download | coredns-acf823cd78d295c4664937ef7ac72b96349a1cf0.tar.gz coredns-acf823cd78d295c4664937ef7ac72b96349a1cf0.tar.zst coredns-acf823cd78d295c4664937ef7ac72b96349a1cf0.zip | |
Metrics2 (#1588)
* plugin/metrics: still need nil check for shutdown
the second prometheus statement will trigger: (on control-C)
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x94f45a]
goroutine 25 [running]:
github.com/coredns/coredns/plugin/metrics.(*Metrics).OnShutdown(0xc420252000, 0x0, 0x0)
/home/miek/g/src/github.com/coredns/coredns/plugin/metrics/metrics.go:107 +0x2a
github.com/coredns/coredns/plugin/metrics.(*Metrics).OnShutdown-fm(0x0, 0x0)
/home/miek/g/src/github.com/coredns/coredns/plugin/metrics/setup.go:39 +0x2a
github.com/mholt/caddy.(*Instance).ShutdownCallbacks(0xc4202c81e0, 0x0, 0x0, 0x0)
/home/miek/g/src/github.com/mholt/caddy/caddy.go:164 +0xb3
github.com/mholt/caddy.allShutdownCallbacks(0x1743935, 0x8, 0x14a1b40)
/home/miek/g/src/github.com/mholt/caddy/sigtrap.go:95 +0x10d
github.com/mholt/caddy.executeShutdownCallbacks.func1()
/home/miek/g/src/github.com/mholt/caddy/sigtrap.go:75 +0x8f
sync.(*Once).Do(0x2256b80, 0xc42036df88)
/home/miek/upstream/go/src/sync/once.go:44 +0xbe
github.com/mholt/caddy.executeShutdownCallbacks(0x174033f, 0x6, 0x0)
/home/miek/g/src/github.com/mholt/caddy/sigtrap.go:71 +0x73
github.com/mholt/caddy.trapSignalsCrossPlatform.func1.1()
/home/miek/g/src/github.com/mholt/caddy/sigtrap.go:61 +0x36
created by github.com/mholt/caddy.trapSignalsCrossPlatform.func1
/home/miek
* comments on why
Diffstat (limited to 'pb')
0 files changed, 0 insertions, 0 deletions