aboutsummaryrefslogtreecommitdiff
path: root/plugin/loop/setup.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2018-12-16 21:48:09 +0000
committerGravatar Yong Tang <yong.tang.github@outlook.com> 2018-12-16 13:48:09 -0800
commit775cf92f038f32fc1e562f61c0fcaaaea9ea5b7e (patch)
tree8b194c0ef9766d8d83be3f9e455d3d943ac5a327 /plugin/loop/setup.go
parent6b8c154441f4f4bcf5c8ee6cff888d28edac81fe (diff)
downloadcoredns-775cf92f038f32fc1e562f61c0fcaaaea9ea5b7e.tar.gz
coredns-775cf92f038f32fc1e562f61c0fcaaaea9ea5b7e.tar.zst
coredns-775cf92f038f32fc1e562f61c0fcaaaea9ea5b7e.zip
plugin/loop: show from -> to (#2400)
Show from and to address when detecting a loop they may aid in debugging. Hard to create a unit test, but this is a startup run with self induced loop: ~~~ corefile .:1053 { loop log forward . 127.0.0.1:1053 } ~~~~ ~~~ :1053 2018-12-16T10:11:03.695Z [INFO] CoreDNS-1.3.0 2018-12-16T10:11:03.695Z [INFO] linux/amd64, go1.11, CoreDNS-1.3.0 linux/amd64, go1.11, 2018-12-16T10:11:03.696Z [FATAL] plugin/loop: Loop (127.0.0.1:51384 -> :1053) detected for zone ".", see https://coredns.io/plugins/loop#troubleshooting. Query: "HINFO 2781022615773629442.4133547885299871809." ~~~ Update the docs and polished that a bit as well. Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/loop/setup.go')
-rw-r--r--plugin/loop/setup.go1
1 files changed, 1 insertions, 0 deletions
diff --git a/plugin/loop/setup.go b/plugin/loop/setup.go
index ba4681cb4..db6821341 100644
--- a/plugin/loop/setup.go
+++ b/plugin/loop/setup.go
@@ -41,6 +41,7 @@ func setup(c *caddy.Controller) error {
addr := net.JoinHostPort(lh, conf.Port)
for time.Now().Before(deadline) {
+ l.setAddress(addr)
if _, err := l.exchange(addr); err != nil {
l.reset()
time.Sleep(1 * time.Second)