aboutsummaryrefslogtreecommitdiff
path: root/plugin
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2022-04-04 15:00:17 -0400
committerGravatar GitHub <noreply@github.com> 2022-04-04 15:00:17 -0400
commit17fca596286287026b93d0691264bc3521457543 (patch)
treef9d4f6c54789b57dcd9e5c5be14519c109f39646 /plugin
parent4d76faa4b454f8b82a124e628eca5e00f1622a92 (diff)
downloadcoredns-17fca596286287026b93d0691264bc3521457543.tar.gz
coredns-17fca596286287026b93d0691264bc3521457543.tar.zst
coredns-17fca596286287026b93d0691264bc3521457543.zip
Comment reason for non-exact match in direct cname loop checks (#5294)
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Diffstat (limited to 'plugin')
-rw-r--r--plugin/backend_lookup.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/plugin/backend_lookup.go b/plugin/backend_lookup.go
index 89db8aac6..d168ab1a1 100644
--- a/plugin/backend_lookup.go
+++ b/plugin/backend_lookup.go
@@ -30,6 +30,7 @@ func A(ctx context.Context, b ServiceBackend, zone string, state request.Request
case dns.TypeCNAME:
if Name(state.Name()).Matches(dns.Fqdn(serv.Host)) {
// x CNAME x is a direct loop, don't add those
+ // in etcd/skydns w.x CNAME x is also direct loop due to the "recursive" nature of search results
continue
}
@@ -104,6 +105,7 @@ func AAAA(ctx context.Context, b ServiceBackend, zone string, state request.Requ
// Try to resolve as CNAME if it's not an IP, but only if we don't create loops.
if Name(state.Name()).Matches(dns.Fqdn(serv.Host)) {
// x CNAME x is a direct loop, don't add those
+ // in etcd/skydns w.x CNAME x is also direct loop due to the "recursive" nature of search results
continue
}
@@ -358,6 +360,7 @@ func TXT(ctx context.Context, b ServiceBackend, zone string, state request.Reque
case dns.TypeCNAME:
if Name(state.Name()).Matches(dns.Fqdn(serv.Host)) {
// x CNAME x is a direct loop, don't add those
+ // in etcd/skydns w.x CNAME x is also direct loop due to the "recursive" nature of search results
continue
}