aboutsummaryrefslogtreecommitdiff
path: root/plugin
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2020-06-24 10:49:42 -0400
committerGravatar GitHub <noreply@github.com> 2020-06-24 07:49:42 -0700
commit47d6e86f58f81ec92bd1e4cf18da58f5382b2ae2 (patch)
tree4abdfafb2dcea10c0bb43c665dcbe65b49faf087 /plugin
parent55e9c2cd7b32bc9b67896fb9a4e85a8e6fd2f409 (diff)
downloadcoredns-47d6e86f58f81ec92bd1e4cf18da58f5382b2ae2.tar.gz
coredns-47d6e86f58f81ec92bd1e4cf18da58f5382b2ae2.tar.zst
coredns-47d6e86f58f81ec92bd1e4cf18da58f5382b2ae2.zip
plugin/cache/forward: Clean up grammar/wording in forward & cache metrics descriptions. (#3971)
* tweak language Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * tweak language Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * typo Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Diffstat (limited to 'plugin')
-rw-r--r--plugin/cache/README.md2
-rw-r--r--plugin/cache/metrics.go2
-rw-r--r--plugin/forward/README.md2
-rw-r--r--plugin/forward/metrics.go2
4 files changed, 4 insertions, 4 deletions
diff --git a/plugin/cache/README.md b/plugin/cache/README.md
index 8e7c24d9e..887acd956 100644
--- a/plugin/cache/README.md
+++ b/plugin/cache/README.md
@@ -73,7 +73,7 @@ If monitoring is enabled (via the *prometheus* plugin) then the following metric
* `coredns_cache_entries{server, type}` - Total elements in the cache by cache type.
* `coredns_cache_hits_total{server, type}` - Counter of cache hits by cache type.
* `coredns_cache_misses_total{server}` - Counter of cache misses.
-* `coredns_cache_prefetch_total{server}` - Counter of cache has prefetched a cached item.
+* `coredns_cache_prefetch_total{server}` - Counter of times the cache has prefetched a cached item.
* `coredns_cache_drops_total{server}` - Counter of responses excluded from the cache due to request/response question name mismatch.
* `coredns_cache_served_stale_total{server}` - Counter of requests served from stale cache entries.
diff --git a/plugin/cache/metrics.go b/plugin/cache/metrics.go
index 3240d5fa6..79aa805c8 100644
--- a/plugin/cache/metrics.go
+++ b/plugin/cache/metrics.go
@@ -33,7 +33,7 @@ var (
Namespace: plugin.Namespace,
Subsystem: "cache",
Name: "prefetch_total",
- Help: "The number of time the cache has prefetched a cached item.",
+ Help: "The number of times the cache has prefetched a cached item.",
}, []string{"server"})
// cacheDrops is the number responses that are not cached, because the reply is malformed.
cacheDrops = prometheus.NewCounterVec(prometheus.CounterOpts{
diff --git a/plugin/forward/README.md b/plugin/forward/README.md
index 60d9b470c..46422b263 100644
--- a/plugin/forward/README.md
+++ b/plugin/forward/README.md
@@ -106,7 +106,7 @@ On each endpoint, the timeouts for communication are set as follows:
If monitoring is enabled (via the *prometheus* plugin) then the following metric are exported:
* `coredns_forward_requests_total{to}` - query count per upstream.
-* `coredns_forward_responses_total{to}` - Counter of responses made per upstream.
+* `coredns_forward_responses_total{to}` - Counter of responses received per upstream.
* `coredns_forward_request_duration_seconds{to}` - duration per upstream interaction.
* `coredns_forward_responses_total{to, rcode}` - count of RCODEs per upstream.
* `coredns_forward_healthcheck_failures_total{to}` - number of failed health checks per upstream.
diff --git a/plugin/forward/metrics.go b/plugin/forward/metrics.go
index 07aa1a6ed..58936caa0 100644
--- a/plugin/forward/metrics.go
+++ b/plugin/forward/metrics.go
@@ -18,7 +18,7 @@ var (
Namespace: plugin.Namespace,
Subsystem: "forward",
Name: "responses_total",
- Help: "Counter of response made per upstream.",
+ Help: "Counter of responses received per upstream.",
}, []string{"rcode", "to"})
RequestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{
Namespace: plugin.Namespace,