aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2020-03-26 09:17:33 +0100
committerGravatar GitHub <noreply@github.com> 2020-03-26 09:17:33 +0100
commit19cfa2960cc415e0e38d36fc9d9325bd636c000e (patch)
tree92862740f97d0378fb0f6dced375fb2d9442271a /test
parenteb23cce1a766ee37cbfc884928f668dac4d0ddff (diff)
downloadcoredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.gz
coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.zst
coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.zip
Cleanup metrics (#3776)
Cleanup a variety of metric issues. * Eliminate department of redundancy "count_total" naming. * Use the plural of the unit when appropriate. (ex, "requests") * Remove label names from metric names where appropriate. (ex, "rcode") * Simplify request metrics by consolidating type label in to the base request counter. * Re-generate man pages. Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/metrics_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/metrics_test.go b/test/metrics_test.go
index cad1a0a87..e79370873 100644
--- a/test/metrics_test.go
+++ b/test/metrics_test.go
@@ -36,7 +36,7 @@ example.com:0 {
}
func TestMetricsRefused(t *testing.T) {
- metricName := "coredns_dns_response_rcode_count_total"
+ metricName := "coredns_dns_responses_total"
corefile := `example.org:0 {
forward . 8.8.8.8:53
@@ -110,7 +110,7 @@ func TestMetricsAuto(t *testing.T) {
t.Fatalf("Could not send message: %s", err)
}
- metricName := "coredns_dns_request_count_total" //{zone, proto, family}
+ metricName := "coredns_dns_requests_total" // {zone, proto, family, type}
data := test.Scrape("http://" + metrics.ListenAddr + "/metrics")
// Get the value for the metrics where the one of the labels values matches "example.org."