aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorGravatar Yong Tang <yong.tang.github@outlook.com> 2020-11-07 10:53:20 -0800
committerGravatar GitHub <noreply@github.com> 2020-11-07 10:53:20 -0800
commit263423edadf60ae2e1a3073d0ebff44f6d729b21 (patch)
tree0d8f4b3e00ed2f39dd0b7d513180c457a98edcd7 /test
parent67f2048bb0e3ac03bfcfdcd3c3e9666351750b4b (diff)
downloadcoredns-263423edadf60ae2e1a3073d0ebff44f6d729b21.tar.gz
coredns-263423edadf60ae2e1a3073d0ebff44f6d729b21.tar.zst
coredns-263423edadf60ae2e1a3073d0ebff44f6d729b21.zip
Setup GitHub Actions for auto remove trailing whitespaces (#4269)
* Setup GitHub Actions for auto remove trailing whitespaces This PR setup GitHub Actions for auto remove trailing whitespaces, if any non-go files are touched (.git directory are ignored) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remove TestTrailingWhitespace in presubmit tests Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * paths and paths-ignore are mutually exlcusive so only keep paths-ignore Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remove redundent bufio import Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Diffstat (limited to 'test')
-rw-r--r--test/presubmit_test.go62
1 files changed, 0 insertions, 62 deletions
diff --git a/test/presubmit_test.go b/test/presubmit_test.go
index f2b4c8bea..5d519d759 100644
--- a/test/presubmit_test.go
+++ b/test/presubmit_test.go
@@ -3,7 +3,6 @@ package test
// These tests check for meta level items, like trailing whitespace, correct file naming etc.
import (
- "bufio"
"fmt"
"go/ast"
"go/parser"
@@ -16,67 +15,6 @@ import (
"unicode"
)
-func TestTrailingWhitespace(t *testing.T) {
- walker := hasTrailingWhitespaceWalker{}
- err := filepath.Walk("..", walker.walk)
-
- if err != nil {
- t.Fatal(err)
- }
-
- if len(walker.Errors) > 0 {
- for _, err = range walker.Errors {
- t.Error(err)
- }
- }
-}
-
-type hasTrailingWhitespaceWalker struct {
- Errors []error
-}
-
-func (w *hasTrailingWhitespaceWalker) walk(path string, info os.FileInfo, _ error) error {
- // Only handle regular files, skip files that are executable and skip file in the
- // root that start with a .
- if !info.Mode().IsRegular() {
- return nil
- }
- if info.Mode().Perm()&0111 != 0 {
- return nil
- }
- if strings.HasPrefix(path, "../.") {
- return nil
- }
- if strings.Contains(path, "/vendor") {
- return nil
- }
-
- file, err := os.Open(path)
- if err != nil {
- return nil
- }
- defer file.Close()
-
- scanner := bufio.NewScanner(file)
- for i := 1; scanner.Scan(); i++ {
- text := scanner.Text()
- trimmed := strings.TrimRightFunc(text, unicode.IsSpace)
- if len(text) != len(trimmed) {
- absPath, _ := filepath.Abs(path)
- w.Errors = append(w.Errors, fmt.Errorf("file %q has trailing whitespace at line %d, text: %q", absPath, i, text))
- }
- }
-
- err = scanner.Err()
-
- if err != nil {
- absPath, _ := filepath.Abs(path)
- err = fmt.Errorf("file %q: %v", absPath, err)
- }
-
- return err
-}
-
func TestFileNameHyphen(t *testing.T) {
walker := hasHyphenWalker{}
err := filepath.Walk("..", walker.walk)