Fix ineffassign (#1959)

* Fix ineffassign

This fix tries to fix ineffassign, as was reported in:
https://goreportcard.com/report/github.com/coredns/coredns#ineffassign

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update setup.go

Revert this one change, so this can be merged.

1 files changed, 2 insertions, 6 deletions

diff --git a/test/server_reverse_test.go b/test/server_reverse_test.go
index 6434d867d..00db410bd 100644
--- a/test/server_reverse_test.go
+++ b/test/server_reverse_test.go
@@ -74,10 +74,8 @@ func TestReverse(t *testing.T) {
 
 	m := new(dns.Msg)
 	for i, tc := range tests {
-		inaddr := tc.addr
-		var err error
 		if !strings.HasSuffix(tc.addr, ".arpa.") {
-			inaddr, err = dns.ReverseAddr(tc.addr)
+			inaddr, err := dns.ReverseAddr(tc.addr)
 			if err != nil {
 				t.Fatalf("Test %d, failed to convert %s", i, tc.addr)
 			}
@@ -122,10 +120,8 @@ func TestReverseInAddr(t *testing.T) {
 
 	m := new(dns.Msg)
 	for i, tc := range tests {
-		inaddr := tc.addr
-		var err error
 		if !strings.HasSuffix(tc.addr, ".arpa.") {
-			inaddr, err = dns.ReverseAddr(tc.addr)
+			inaddr, err := dns.ReverseAddr(tc.addr)
 			if err != nil {
 				t.Fatalf("Test %d, failed to convert %s", i, tc.addr)
 			}