aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorGravatar mrasu <m.rasu.hitsuji@gmail.com> 2019-02-09 23:39:51 +0900
committerGravatar Miek Gieben <miek@miek.nl> 2019-02-09 14:39:51 +0000
commit67932239489d955a0af69b41d78282ad5ed29a34 (patch)
tree80633d4beb42edfcc111a2dcfb4df1c586ce9435 /test
parentab4262d7ebaf53639feb0540db40b9298cf3c38e (diff)
downloadcoredns-67932239489d955a0af69b41d78282ad5ed29a34.tar.gz
coredns-67932239489d955a0af69b41d78282ad5ed29a34.tar.zst
coredns-67932239489d955a0af69b41d78282ad5ed29a34.zip
Fix etcd_cache_test to runnable multiple times. (#2546)
Currently, when you run `TestEtcdCredentials` at etcd_credentials_test.go multiple times without clearing data of etcd, you will get following errors. ``` etcd_credentials_test.go:38: Failed to create root role: etcdserver: role name already exists etcd_credentials_test.go:41: Failed to create user: etcdserver: user name already exists ```
Diffstat (limited to 'test')
-rw-r--r--test/etcd_credentials_test.go12
1 files changed, 12 insertions, 0 deletions
diff --git a/test/etcd_credentials_test.go b/test/etcd_credentials_test.go
index 70586e4d1..ebcc20b16 100644
--- a/test/etcd_credentials_test.go
+++ b/test/etcd_credentials_test.go
@@ -37,9 +37,21 @@ func TestEtcdCredentials(t *testing.T) {
if _, err := etc.Client.RoleAdd(ctx, "root"); err != nil {
t.Errorf("Failed to create root role: %s", err)
}
+ defer func() {
+ if _, err := etc.Client.RoleDelete(ctx, "root"); err != nil {
+ t.Errorf("Failed to delete root role: %s", err)
+ }
+ }()
+
if _, err := etc.Client.UserAdd(ctx, username, password); err != nil {
t.Errorf("Failed to create user: %s", err)
}
+ defer func() {
+ if _, err := etc.Client.UserDelete(ctx, username); err != nil {
+ t.Errorf("Failed to delete user: %s", err)
+ }
+ }()
+
if _, err := etc.Client.UserGrantRole(ctx, username, "root"); err != nil {
t.Errorf("Failed to assign role to root user: %v", err)
}