diff options
| -rw-r--r-- | plugin/forward/setup_test.go | 5 | ||||
| -rw-r--r-- | plugin/pkg/parse/host.go | 3 | ||||
| -rw-r--r-- | plugin/pkg/parse/host_test.go | 5 |
3 files changed, 13 insertions, 0 deletions
diff --git a/plugin/forward/setup_test.go b/plugin/forward/setup_test.go index 0ac5c3e18..0949e0935 100644 --- a/plugin/forward/setup_test.go +++ b/plugin/forward/setup_test.go @@ -139,6 +139,8 @@ nameserver 10.10.255.253`), 0666); err != nil { }{ // pass {`forward . ` + resolv, false, "", []string{"10.10.255.252:53", "10.10.255.253:53"}}, + // fail + {`forward . /dev/null`, true, "no nameservers", nil}, } for i, test := range tests { @@ -168,6 +170,9 @@ nameserver 10.10.255.253`), 0666); err != nil { } } } + if test.shouldErr { + continue + } for _, p := range f.proxies { p.health.Check(p) // this should almost always err, we don't care it shouldn't crash } diff --git a/plugin/pkg/parse/host.go b/plugin/pkg/parse/host.go index c1b7d23e0..67cfa86d8 100644 --- a/plugin/pkg/parse/host.go +++ b/plugin/pkg/parse/host.go @@ -69,6 +69,9 @@ func HostPortOrFile(s ...string) ([]string, error) { } servers = append(servers, h) } + if len(servers) == 0 { + return servers, fmt.Errorf("no nameservers found") + } return servers, nil } diff --git a/plugin/pkg/parse/host_test.go b/plugin/pkg/parse/host_test.go index 1c23c5bee..274eed225 100644 --- a/plugin/pkg/parse/host_test.go +++ b/plugin/pkg/parse/host_test.go @@ -54,6 +54,11 @@ func TestHostPortOrFile(t *testing.T) { "[fd01::1%ens3]:153", false, }, + { + "8.9.1043", + "", + true, + }, } err := ioutil.WriteFile("resolv.conf", []byte("nameserver 127.0.0.1\n"), 0600) |