aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--plugin/health/health_test.go2
-rw-r--r--plugin/ready/ready_test.go6
-rw-r--r--plugin/test/scrape.go3
-rw-r--r--plugin/trace/trace_test.go3
4 files changed, 7 insertions, 7 deletions
diff --git a/plugin/health/health_test.go b/plugin/health/health_test.go
index ba6b14c7a..c49a5d73d 100644
--- a/plugin/health/health_test.go
+++ b/plugin/health/health_test.go
@@ -22,7 +22,7 @@ func TestHealth(t *testing.T) {
if err != nil {
t.Fatalf("Unable to query %s: %v", address, err)
}
- if response.StatusCode != 200 {
+ if response.StatusCode != http.StatusOK {
t.Errorf("Invalid status code: expecting '200', got '%d'", response.StatusCode)
}
content, err := io.ReadAll(response.Body)
diff --git a/plugin/ready/ready_test.go b/plugin/ready/ready_test.go
index fff19cc91..414541c2e 100644
--- a/plugin/ready/ready_test.go
+++ b/plugin/ready/ready_test.go
@@ -32,7 +32,7 @@ func TestReady(t *testing.T) {
if err != nil {
t.Fatalf("Unable to query %s: %v", address, err)
}
- if response.StatusCode != 503 {
+ if response.StatusCode != http.StatusServiceUnavailable {
t.Errorf("Invalid status code: expecting %d, got %d", 503, response.StatusCode)
}
response.Body.Close()
@@ -48,7 +48,7 @@ func TestReady(t *testing.T) {
if err != nil {
t.Fatalf("Unable to query %s: %v", address, err)
}
- if response.StatusCode != 200 {
+ if response.StatusCode != http.StatusOK {
t.Errorf("Invalid status code: expecting %d, got %d", 200, response.StatusCode)
}
response.Body.Close()
@@ -62,7 +62,7 @@ func TestReady(t *testing.T) {
if err != nil {
t.Fatalf("Unable to query %s: %v", address, err)
}
- if response.StatusCode != 200 {
+ if response.StatusCode != http.StatusOK {
t.Errorf("Invalid status code: expecting %d, got %d", 200, response.StatusCode)
}
response.Body.Close()
diff --git a/plugin/test/scrape.go b/plugin/test/scrape.go
index 7847e39d4..7ac22d531 100644
--- a/plugin/test/scrape.go
+++ b/plugin/test/scrape.go
@@ -19,7 +19,6 @@
//
// result := Scrape("http://localhost:9153/metrics")
// v := MetricValue("coredns_cache_capacity", result)
-//
package test
import (
@@ -217,7 +216,7 @@ func makeBuckets(m *dto.Metric) map[string]string {
func fetchMetricFamilies(url string, ch chan<- *dto.MetricFamily) {
defer close(ch)
- req, err := http.NewRequest("GET", url, nil)
+ req, err := http.NewRequest(http.MethodGet, url, nil)
if err != nil {
return
}
diff --git a/plugin/trace/trace_test.go b/plugin/trace/trace_test.go
index 940eb6b02..c260501cc 100644
--- a/plugin/trace/trace_test.go
+++ b/plugin/trace/trace_test.go
@@ -3,6 +3,7 @@ package trace
import (
"context"
"errors"
+ "net/http"
"net/http/httptest"
"testing"
@@ -152,7 +153,7 @@ func TestTrace_DOH_TraceHeaderExtraction(t *testing.T) {
}
q := new(dns.Msg).SetQuestion("example.net.", dns.TypeA)
- req := httptest.NewRequest("POST", "/dns-query", nil)
+ req := httptest.NewRequest(http.MethodPost, "/dns-query", nil)
outsideSpan := m.StartSpan("test-header-span")
outsideSpan.Tracer().Inject(outsideSpan.Context(), opentracing.HTTPHeaders, opentracing.HTTPHeadersCarrier(req.Header))